Scroll to content pane when editing a user (#13551)

matomo-org · Oct 7, 2018 · 475022f · 475022f
1 parent b1ff5e6
commit 475022f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/plugins/UsersManager/angularjs/users-manager/users-manager.component.html b/plugins/UsersManager/angularjs/users-manager/users-manager.component.html
@@ -29,7 +29,7 @@
             </div>
 
             <piwik-paged-users-list
-                on-edit-user="$ctrl.isEditing = true; $ctrl.userBeingEdited = user;"
+                on-edit-user="$ctrl.onEditUser(user)"
                 on-change-user-role="$ctrl.onChangeUserRole(users, role)"
                 on-delete-user="$ctrl.onDeleteUser(users)"
                 on-search-change="$ctrl.searchParams = params; $ctrl.fetchUsers();"

diff --git a/plugins/UsersManager/angularjs/users-manager/users-manager.component.js b/plugins/UsersManager/angularjs/users-manager/users-manager.component.js
@@ -22,9 +22,9 @@
         controller: UsersManagerController
     });
 
-    UsersManagerController.$inject = ['$element', 'piwikApi', '$q'];
+    UsersManagerController.$inject = ['$element', 'piwik', 'piwikApi', '$q', '$timeout'];
 
-    function UsersManagerController($element, piwikApi, $q) {
+    function UsersManagerController($element, piwik, piwikApi, $q, $timeout) {
         var vm = this;
         vm.isEditing = false;
         vm.isCurrentUserSuperUser = true;
@@ -38,6 +38,7 @@
         vm.$onInit = $onInit;
         vm.$onChanges = $onChanges;
         vm.$onDestroy = $onDestroy;
+        vm.onEditUser = onEditUser;
         vm.onDoneEditing = onDoneEditing;
         vm.showAddExistingUserModal = showAddExistingUserModal;
         vm.onChangeUserRole = onChangeUserRole;
@@ -167,6 +168,12 @@
             });
         }
 
+        function onEditUser(user) {
+            piwik.helper.lazyScrollToContent();
+            vm.isEditing = true;
+            vm.userBeingEdited = user;
+        }
+
         function onDoneEditing(isUserModified) {
             vm.isEditing = false;
             if (isUserModified) { // if a user was modified, we must reload the users list