Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not limit max password length #10235

Closed
mattab opened this Issue Jun 16, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@mattab
Copy link
Member

mattab commented Jun 16, 2016

Currently, password is limited to maximum 80 characters. We should not limit max password length as it is not a standard practise. Follows up #6632 #4558

@mattab mattab added the Help wanted label Jun 16, 2016

@mattab mattab added this to the 3.0.0 milestone Jun 16, 2016

@blueelvis

This comment has been minimized.

Copy link
Contributor

blueelvis commented Jul 11, 2016

We need to define a theoretical limit. How about we use the constant PHP_INT_MAX and use that as the theoretical max?

Depending on the architecture maximum value would be -

32-bit builds of PHP: 2,147,483,647 (~ ± 2 billion)
64-bit builds of PHP: 9,223,372,036,854,775,807 (~ ± 9 quintillion)

@blueelvis

This comment has been minimized.

Copy link
Contributor

blueelvis commented Jul 15, 2016

@mattab - What say?

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Jul 18, 2016

@blueelvis since there will be other limits hit before we hit the 32-bit limit.. I think it's not needed to put in the limit and we can simply accept all strings as they come (while still enforcing the min password length)

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Aug 3, 2016

Kudos to @blueelvis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.