Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik 3 requires PHP 5.5.9 #10380

Closed
mattab opened this Issue Aug 8, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@mattab
Copy link
Member

commented Aug 8, 2016

Steps to take to effectively increase PHP requirements in Piwik:

Follows up: #8156

@mattab mattab added the Enhancement label Aug 8, 2016

@mattab mattab added this to the 3.0.0-b1 milestone Aug 8, 2016

@mattab mattab changed the title Piwik 3 requires PHP 5 Piwik 3 requires PHP 5.5 Aug 8, 2016

@tsteur

This comment has been minimized.

Copy link
Member

commented Sep 12, 2016

increase requirements in source code: https://github.com/piwik/piwik/blob/master/core/testMinimumPhpVersion.php

is done. We need to decide if we require at least 5.5.0 or maybe a little higher version such as 5.5.9 . Not sure if there are some weird problems etc in 5.5.0 or 5.5.1 ...

@tsteur

This comment has been minimized.

Copy link
Member

commented Sep 13, 2016

Drupal 8 (https://www.drupal.org/docs/7/system-requirements/overview and https://www.drupal.org/node/2508231 ) and Symfony (http://symfony.com/doc/current/reference/requirements.html ) require PHP 5.5.9 so it might be a good idea to directly require 5.5.9 as well. Gives us the possibility to use some Symfony components eventually etc

@tsteur

This comment has been minimized.

Copy link
Member

commented Sep 13, 2016

ping @mattab @sgiehl any thoughts?

@sgiehl

This comment has been minimized.

Copy link
Member

commented Sep 13, 2016

Other projects used PHP 5.5.9 for new requirement, as well. So guess that should be fine.
Examples:

@tsteur

This comment has been minimized.

Copy link
Member

commented Sep 13, 2016

Awesome. Seeing Guzzle and the AWS SDK require 5.5.9 as well. Guzzle might be interesting for us to use eventually.
@matt can you confirm re 5.5.9 re usage of Piwik etc?

@mattab

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2016

5.5.9 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.