New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing ALT+d keyboard combination should not open calendar #11498

Closed
mattab opened this Issue Mar 19, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@mattab
Member

mattab commented Mar 19, 2017

Recently we added some keyboard shortcuts #5230 (comment)

  • z for Zen mode
  • s to open Segment selector
  • w to open Website selector
  • d to open calendar (d stands for Date)
  • f to open the search (f stands for Find)

Those shortcuts are sometimes triggered when a combination of keys is pressed including one of them. For example ALT+D triggers the Calendar shortcut.

The goal of this ticket is to make sure that those shortcuts are not triggered when ALT+key is pressed. Because for example ALT+D is supposed to go in the address bar in most browsers, and Piwik would break usability of the browser.

@mattab mattab added this to the 3.0.3 milestone Mar 19, 2017

@mattab mattab added the c: Usability label Mar 19, 2017

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 19, 2017

This seems to be a firefox only problem and was reported in the Mousetraps issue tracker years ago.
We might need to patch this library if we would like to fix the behavior I guess

@CheweyZ

This comment has been minimized.

Contributor

CheweyZ commented Mar 19, 2017

As an idea how about we change the key bind to C as this way it would also imply C for calendar although this may have conflict with ctrl+c

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 20, 2017

that won't solve the problem. It's not only ALT+D. there are other letters in firefox as well, that wouldn't work anymore. ALT+S for example would normally be "Save"

@sgiehl sgiehl self-assigned this Mar 20, 2017

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 20, 2017

I'll try to find a workaround to prevent our event from being fired if the ALT key is pressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment