New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New dimensions "Website ID" and "Website name" #12409

Closed
mattab opened this Issue Jan 7, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@mattab
Member

mattab commented Jan 7, 2018

It would be useful to introduce two new dimensions:

  1. Website ID (or measurable)
  2. Website name (or measurable)

Then Custom Reports could leverage these new dimensions and allow creating custom reports on Roll-Ups broken down by Website id or website name.

For these dimensions I reckon we don't need to create new segments. Although having segments for website id/name could be possibly useful to segment a roll-up and filter out some sites, it hasn't been requested yet.

The dimensions should be available when used in the "Top level" of the report (ie. the first dimension added), and also when the dimension eg. "Website name" is added below, for example "Country > Product sold > Website name" should list, for any given country and product comparison, all of the website that sold this product.

Testing

To check this new feature works as expected, we should create a Custom Report on a Roll-up, where the custom report includes the Website name and/or Website ID. The generated custom report should let us drill down into any particular website.

@mattab mattab added this to the 3.4.0 milestone Jan 7, 2018

@mattab mattab modified the milestones: 3.5.0, 3.4.0, 3.4.1 Mar 19, 2018

@mattab mattab added the Enhancement label Mar 26, 2018

@diosmosis diosmosis self-assigned this Mar 26, 2018

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 27, 2018

Member

@mattab couple questions:

  1. Is this the kind of report you're expecting?

image

  1. Is there value in having both website ID & website name dimensions? If yes, for website ID, should the report display the ID or the website name? If both dimensions display website name, then what's the use of having both of them?

  2. Would it be better to just have the website name as the label or would Website Name [ID = 3] be more useful? I think the latter would be more useful, but maybe it's just clutter...

Member

diosmosis commented Mar 27, 2018

@mattab couple questions:

  1. Is this the kind of report you're expecting?

image

  1. Is there value in having both website ID & website name dimensions? If yes, for website ID, should the report display the ID or the website name? If both dimensions display website name, then what's the use of having both of them?

  2. Would it be better to just have the website name as the label or would Website Name [ID = 3] be more useful? I think the latter would be more useful, but maybe it's just clutter...

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 27, 2018

Member
  1. Any other places dimension metadata is used? Will need to test those places too.
Member

diosmosis commented Mar 27, 2018

  1. Any other places dimension metadata is used? Will need to test those places too.
@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Mar 27, 2018

Member
  1. yes
  2. yes, displaying website ID only sounds good
  3. only website name
  4. not that I know, but tests should tell us otherwise, hopefully
Member

mattab commented Mar 27, 2018

  1. yes
  2. yes, displaying website ID only sounds good
  3. only website name
  4. not that I know, but tests should tell us otherwise, hopefully
@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 27, 2018

Member

@mattab FYI, there is already an IdSite dimension that uses the site name column. Do you have a problem w/ using that instead of two dimensions? https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/CoreHome/Columns/IdSite.php

Note: this is what is being used in the screenshot (I had to modify it a bit first).

Member

diosmosis commented Mar 27, 2018

@mattab FYI, there is already an IdSite dimension that uses the site name column. Do you have a problem w/ using that instead of two dimensions? https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/CoreHome/Columns/IdSite.php

Note: this is what is being used in the screenshot (I had to modify it a bit first).

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Mar 27, 2018

Member

in the UI, it is needed to have the website ID as its own dimension, as well as the website name as its own

in the backend, they would be the same based on idsite

Member

mattab commented Mar 27, 2018

in the UI, it is needed to have the website ID as its own dimension, as well as the website name as its own

in the backend, they would be the same based on idsite

@diosmosis

This comment has been minimized.

Show comment
Hide comment
@diosmosis

diosmosis Mar 27, 2018

Member

@mattab could you elaborate on why? I don't have a problem w/ trying to do this, but I feel like there's a reason for why the IdSite dimension uses the idsite column & selects the name for the value. I want to make sure I understand the situation completely.

EDIT: got it, just display

Member

diosmosis commented Mar 27, 2018

@mattab could you elaborate on why? I don't have a problem w/ trying to do this, but I feel like there's a reason for why the IdSite dimension uses the idsite column & selects the name for the value. I want to make sure I understand the situation completely.

EDIT: got it, just display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment