New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor log actions icons alignment #12770

Open
mattab opened this Issue Apr 26, 2018 · 9 comments

Comments

Projects
None yet
4 participants
@mattab
Copy link
Member

mattab commented Apr 26, 2018

Minor feedback: in Visitor Log, some icons are not vertically aligned.
In this example you can see that while the Conversion icon is middle aligned, the Content Tracking icons are not (they are slightly too high).

Example 1: content interaction too high

content tracking

Example 2: content impression too high

sne

Example 3: outlinks too low

too low

@fdellwing

This comment has been minimized.

Copy link
Contributor

fdellwing commented Apr 26, 2018

Should be possible with CSS.

plugins/Live/stylesheets/live.less - Line 295ff

.action-list-action-icon {
    display: inline;
    margin: 2px 3px 0 0;
    max-height: 16px;
 
    &.outlink {
      margin: 7px 3px 0 0;
    }
}

outlink is the action.type here coming from <img src='{{ action.icon }}' class="action-list-action-icon {{ action.type }}"> in plugins/Live/templates/_actionCommon.twig

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Apr 30, 2018

@fdellwing thanks for the suggestion. Would be great if you can test the change works and then create a Pull request 👍

@mattab mattab added this to the 3.6.0 milestone Apr 30, 2018

@fdellwing

This comment has been minimized.

Copy link
Contributor

fdellwing commented May 2, 2018

Sadly I do not have a instance with all with symbols. Will look into this.

@mattab mattab modified the milestones: 3.6.0, 3.5.1 May 16, 2018

@diosmosis diosmosis modified the milestones: 3.6.0, 3.7.0 Jul 24, 2018

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Oct 8, 2018

Hi @fdellwing
Would you maybe able to test your changes and open a PR so we can see the failing tests and if it fixes issue?

@fdellwing

This comment has been minimized.

Copy link
Contributor

fdellwing commented Oct 8, 2018

@mattab
Is there somethere an otherview with all possible action types? I have sadly no time for researching that myself.

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Oct 8, 2018

Some are handled here: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/VisitorDetails.php#L71-L85
Additionally some plugins add some more. like event or form

@fdellwing

This comment has been minimized.

Copy link
Contributor

fdellwing commented Oct 8, 2018

The problem is, we do not have all this action type on our site (we have no ecommerce) and the CSS needs to be handcrafted for every single type.

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Oct 8, 2018

You could generate a tracking api request with the Contents parameter see:

Optional Content Tracking info

  • c_n — The name of the content. For instance 'Ad Foo Bar'
  • c_p — The actual content piece. For instance the path to an image, video, audio, any text
  • c_t — The target of the content. For instance the URL of a landing page
  • c_i — The name of the interaction with the content. For instance a 'click'

To track a content impression set c_n and optionally c_p and c_t. To track a content interaction set c_i and c_n and optionally c_p and c_t. To map an interaction to an impression make sure to set the same value for c_n and c_p. It is recommended to set a value for c_p.

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Jan 6, 2019

might be solved with a redesign in #13916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment