Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Geoip FAQs and Docs to explain Geoip2 (and remove docs about Geoip1) #12964

Closed
mattab opened this issue May 23, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@mattab
Copy link
Member

commented May 23, 2018

Let's update the following Guides & FAQs:

So they reference Geoip2 instead of Geoip. We can then remove the Geoip1 doc I would say (it will still be in the archive.org history if needed).

@mattab mattab added this to the 3.6.0 milestone May 23, 2018

@sgiehl

This comment has been minimized.

Copy link
Member

commented May 23, 2018

updated the first one. will try to tackle the remaining ones the coming days

@sgiehl

This comment has been minimized.

Copy link
Member

commented May 24, 2018

I've updated some more faqs/docs. Remaining ones are about setting up apache/nginx modules. Not sure if that's something I'm able to describe well, but I'll give it a try tomorrow.

@mattab

This comment has been minimized.

Copy link
Member Author

commented May 31, 2018

Thanks @sgiehl - let me know if it's do-able to update the remaining FAQs. If not do-able maybe we can delete them otherwise...

@sgiehl

This comment has been minimized.

Copy link
Member

commented May 31, 2018

@mattab Those are the docs for installing the modules:

https://maxmind.github.io/mod_maxminddb/
https://github.com/leev/ngx_http_geoip2_module/blob/master/README.md#installing

We currently link to those pages within Matomo. Not sure if it's worth to rewrite their READMEs and add a small part how to configure the variables in Matomo

@mattab

This comment has been minimized.

Copy link
Member Author

commented May 31, 2018

maybe it makes sense to simply link to these resources from the FAQ? and remove most of the text otherwise

@sgiehl

This comment has been minimized.

Copy link
Member

commented May 31, 2018

@mattab I've updated the FAQs. They are now mainly mentioning the links. Feel free to remove them if they don't have enough value anymore.

@mattab

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2018

Thank you for updating FAQs and the guide, looks good to me 👍

@mattab mattab closed this Jun 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.