New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace our github service "Piwik Plugins" with an app "Matomo Plugins" or webhook #13050

Closed
tsteur opened this Issue Jun 10, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Jun 10, 2018

image

On October 1st, we otherwise won't receive any new plugins anymore on the Marketplace and neither any plugin updates see https://developer.github.com/changes/2018-04-25-github-services-deprecation/ and https://developer.github.com/apps/differences-between-apps/#about-github-apps/ and https://developer.github.com/webhooks/

October 1st will be soon, especially if something needs to be reviewed or added by Github or something so we should aim to have finished by August 1st maybe? Also considering we need to notify all developers and give them time to upgrade etc. This means we might need to modify our current hook and if the old service is being used, decline the plugin submission and send the author(s) an email update with instructions on how to use the new webhook or app. We should have this active for 1 or 2 months (better 3) so it is really important to finish this as early as possible ideally.

Also we will need to publish a blog post and ideally notify some of the developers (we don't have contact details for all of them) by email and update the marketplace guide etc.

@tsteur tsteur added the Major label Jun 10, 2018

@tsteur tsteur added this to the 3.7.0 milestone Jun 10, 2018

@Findus23

This comment has been minimized.

Member

Findus23 commented Jun 10, 2018

Depending on how similar the new GitHub Apps API is to regular webhooks it may make sense to support both on the https://plugins.matomo.org/postreceive-hook (or a similar) endpoint.
That way everyone could simply enable the app without configuration or manually add the webhook if they are using something else than github.

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 20, 2018

Marketplace is updated to support webhooks. Also updated the guide on https://developer.matomo.org/guides/distributing-your-plugin#activate-the-piwik-plugins-webhook

We will soon send emails to developers automatically if/when they release a new version through the GitHub service.

We might also email developers once in case they don't release a new version in the meantime.

@tsteur tsteur self-assigned this Sep 20, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 20, 2018

Updated all our repositories to use the new webhook, and developers should now be notified when they release new version and use outdated github service.

@tsteur tsteur closed this Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment