Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google images not detected anymore #1348

Closed
mattab opened this issue May 10, 2010 · 3 comments
Closed

Google images not detected anymore #1348

mattab opened this issue May 10, 2010 · 3 comments
Milestone

Comments

@mattab
Copy link
Member

@mattab mattab commented May 10, 2010

It seems that google images is not detected correctly anymore. Maybe their URL scheme changed, or there is a regression in Piwik.

@halfdan
Copy link
Member

@halfdan halfdan commented May 10, 2010

In what way?

I can confirm that Google Images is not detected if you do a search for an image which then gets viewed in a frame (the URL is "www.google.com/imgres?", search parameter "q").

In core/DataFiles/SearchEngines.php Google Images is defined with:

// Google Images
                'images.google.com'                     => array('Google Images', 'q', 'images?q={k}'),

I can't say for sure that "images?" isn't used anymore, but we should definetely add 'imgres?q={k}'. The big problem here is that the subdomain has switched from images.google.com to www.google.com.

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented May 10, 2010

Images is still used. As far as I can see the only difference is the change from images.google.com to google.com.

Here is an old referrer that works with piwik:

http://images.google.com/imgres?imgurl=http://imagedomain.com/media/456/331/files/4563314.jpg&imgrefurl=http://www.mydomain.com/product/55DSL-Men-JETMOON-JACKET-Jackets-Coats-Casual-Jackets.html&usg=__JJ9PXqlMTi497eCQDQt5uzkjFso=&h=580&w=464&sz=56&hl=en&start=3&um=1&tbnid=ui0JTvHMwEmD5M:&tbnh=134&tbnw=107&prev=/images%3Fq%3Dsatin%2Bjackets%2Bwomen%26hl%3Den%26client%3Dfirefox-a%26channel%3Ds%26rls%3Dorg.mozilla:en-US:official%26hs%3DJd7%26sa%3DN%26um%3D1

and here is the new url not working with piwik:

http://www.google.com/imgres?imgurl=http://www.imagedomain.com/zoom/34782_ZOOM.jpg&imgrefurl=http://www.mydomain.com/product/Omala-Govindra-Tank-XS-Brown-and-Chile.html&usg=__BD6z_JrJRAFjScDRhj4Tp8Vm_Zo=&h=610&w=465&sz=248&hl=en&start=3&itbs=1&tbnid=aiNVNce9-ZYAPM:&tbnh=136&tbnw=104&prev=/images%3Fq%3DFull%2BSupport%2BTummy%26hl%3Den%26safe%3Doff%26sa%3DG%26gbv%3D2%26tbs%3Disch:1

@mattab
Copy link
Member Author

@mattab mattab commented May 13, 2010

(In [2170]) Fixes #1348 detecting the new google images style URL + unit test

@mattab mattab added this to the Piwik 0.6.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants