New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML in report documentation is shown plain text #13668

Closed
sgiehl opened this Issue Nov 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@sgiehl
Member

sgiehl commented Nov 5, 2018

Some report documentation contains some HTML tags. Currently the filter rawSafeDecoded is used on that attribute, which causes all HTML-tags to be encoded.

Instead we might use the raw filter, but need to ensure that possible user input is encoded if there is any in some report documentation.

image

Note: This also regressed in the UI tests (https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/30903/UIIntegrationTest_actions_pages_tooltip_help.png)

@sgiehl sgiehl added this to the 3.7.0 milestone Nov 5, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Nov 5, 2018

It would be good if the raw filter be only applied when a viewdatatable config option is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment