New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://builds-artifacts.matomo.org shows PHP error messages / warnings #14067

Closed
hannob opened this Issue Feb 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@hannob
Copy link

hannob commented Feb 3, 2019

By sending a cookie with a special char one can trigger a PHP warning:

curl --cookie 'PHPSESSID=äöü' https://builds-artifacts.matomo.org

The PHP warning will be shown within the HTML output:

<b>Warning</b>:  SessionHandler::write(): The session id is too long or contains illegal characters, valid characters are a-z, A-Z, 0-9 and '-,' in <b>/home/piwik-builds-artifacts/ui-tests-viewer/vendor/symfony/http-foundation/Session/Storage/Proxy/SessionHandlerProxy.php</b> on line <b>77</b><br />

It is generally recommended to never enable displaying PHP errors in production systems. While this warning is harmless, other error types can contain sensitive information like passwords.

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Feb 3, 2019

Cheers, we changed it there.

@tsteur tsteur closed this Feb 3, 2019

@tsteur tsteur added the answered label Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment