Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When deleting a segment, do a soft delete instead of a hard delete #14826

Closed
tsteur opened this issue Aug 28, 2019 · 0 comments · Fixed by #14846

Comments

@tsteur
Copy link
Member

commented Aug 28, 2019

We already have a flag deleted in segments. When we delete a segment, it should actually keep the segment entry instead of deleting it fully. This allows us to better delete orphaned segments from archives etc. We should also updated the ts_last_edit in the segment table and set it to now() when soft deleting the segment.

@tsteur tsteur added the Enhancement label Aug 28, 2019
@tsteur tsteur added this to the 3.12.0 milestone Aug 28, 2019
@katebutler katebutler self-assigned this Sep 2, 2019
@tsteur tsteur closed this in #14846 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.