Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visits with a User-Agent specified in 'Website > Excluded User Agents' are sometimes still tracked #14880

Open
mattab opened this issue Sep 10, 2019 · 0 comments

Comments

@mattab
Copy link
Member

commented Sep 10, 2019

Specifying User-agent to exclude for a website does not work.
Visits with a User-Agent specified in 'Website > Excluded User Agents' are sometimes still tracked.

Reproduce

  • In Administration > Global websites settings > Global list of user agents to exclude, check that Enable website specific user agent exclusion is un-checked (this is the default)
  • Go to Administration > Websites > Edit
  • Under "Excluded User Agents", enter iplabel and click Save
  • Visit matomo.php?idsite=1&rec=1&test&debug=1&ua=Mozilla/5.0 (X11; CrOS x86_64 8172.45.0 ;iplabel) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.64 Safari/537.36&debug=1 to generate a request with a user agent containing iplabel
  • Got: the visit is tracked.
  • Expected instead: visit excluded.

Bug origin

Once we click the checkbox Enable website specific user agent exclusion. under Administration > Global websites settings > Global list of user agents to exclude, then the User agent specified in the "edit website" works as expected and the visit is excluded.

Solutions

  • either remove that checkbox completely and always enable this feature
  • or leave the checkbox and hide the "excluded user agent" setting in the Website Edit screen. + also throw an exception in the API if the value is set on a website.

@mattab mattab added this to the 3.12.0 milestone Sep 10, 2019

@katebutler katebutler self-assigned this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.