New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker API improvements : enable set IP and set server date & time #1553

Closed
mattab opened this Issue Aug 5, 2010 · 9 comments

Comments

Projects
None yet
4 participants
@mattab
Member

mattab commented Aug 5, 2010

Tracker API allows to record visits, pages and goal conversions using http rest API. Commonly users would have a webserver make the request to Piwik to record visits. This causes piwik to read the visit/page/goal conversion IP as being the server IP issuing the request to piwik.

This could cause discrepancies or generally wrong user data. It would be nice to be able to customize the IP and server time that Piwik uses in the tracker.

It is critical that these 2 attributes can only be set by the Super User, otherwise anyone could record fake time/ fake IP visits in a piwik instance. I suggest we check and require super user token_auth in the piwik.php request to allow setting IP + server time.

Note that in tests, we already set these 2 parameters. To allow this, the proxy-piwik.php hack is used. This mechanism could then be removed to use the token_auth mechanism.

@mattab

This comment has been minimized.

Member

mattab commented Aug 5, 2010

Note: Image tracker (simple or advanced) solutions are not affected by the "wrong IP" issue, as the browser itself does the request to Piwik, so IP is set correctly to visitor IP.

@anonymous-piwik-user

This comment has been minimized.

anonymous-piwik-user commented Sep 22, 2010

Is there any updates? Will this feature implemented in next release.

@robocoder

This comment has been minimized.

Contributor

robocoder commented Sep 22, 2010

No update yet. Not planned for 1.1, but I'll put it on the current milestone so that it has higher near-term visibility.

@anonymous-piwik-user

This comment has been minimized.

anonymous-piwik-user commented Oct 22, 2010

Who is current owner of this feature?

@robocoder

This comment has been minimized.

Contributor

robocoder commented Oct 22, 2010

Matt or myself... whoever gets to it first. Of course, you're welcome to submit a patch... ;)

@zawadzinski

This comment has been minimized.

Contributor

zawadzinski commented Feb 19, 2011

Attachment: Allow overriding ip & serverdate time in Tracking API if proper super user token_auth given.
1553.patch

@zawadzinski

This comment has been minimized.

Contributor

zawadzinski commented Feb 19, 2011

@vipsoft a patch resolving the issue attached

@robocoder

This comment has been minimized.

Contributor

robocoder commented Feb 19, 2011

Thanks, maciej. (Don't you still have commit privileges?)

In r3945, fixes #1553. Accidentally checked in with piwik.js changes for #2072.

@robocoder

This comment has been minimized.

Contributor

robocoder commented Feb 21, 2011

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment