Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure performance timings are sent as integer values #17371

Closed
MichaelRoosz opened this issue Mar 22, 2021 · 3 comments
Closed

Ensure performance timings are sent as integer values #17371

MichaelRoosz opened this issue Mar 22, 2021 · 3 comments
Assignees
Milestone

Comments

@MichaelRoosz
Copy link
Contributor

MichaelRoosz commented Mar 22, 2021

I am currently testing Matomo 4.2.1.

The new Performance Report feature is not working at all:

  • in matomo_log_link_visit_action the only field with non-NULL data is time_network and its always 0
  • the other fields are always NULL
  • -> Reports are empty

This is what the browsers are sending:

chrome
pf_net: 0
pf_srv: 1.150000000052387
pf_tfr: 1.2499999993451638

firefox
pf_net: 0
pf_srv: 2
pf_tfr: 1

  • floats in chrome seem strange as the backend seems to expect integers
  • the values 0/1/2 look like seconds but I guess we want milliseconds?

-> the performance feature seems completely broken at this time

@MichaelRoosz MichaelRoosz added the Potential Bug Something that might be a bug, but can't be reproduced (yet). label Mar 22, 2021
@sgiehl
Copy link
Member

sgiehl commented Mar 22, 2021

@MichaelRoosz thanks for creating the issue. Actually both values should be in milliseconds.
I'll prepare a PR to round the values, so we use integer in all cases.
Not sure if the float values might cause problems when storing them in database..

@diosmosis
Copy link
Member

Might be related to #17259

@sgiehl
Copy link
Member

sgiehl commented Nov 13, 2022

There had been some fixed aroud the Performance Timing tracking. I assume this one should have been fixed as well.
@MichaelRoosz If you still have an issue with this, please let us know, so we can reopen the issue. Thanks.

@sgiehl sgiehl closed this as completed Nov 13, 2022
@sgiehl sgiehl removed the Potential Bug Something that might be a bug, but can't be reproduced (yet). label Nov 13, 2022
@elabuwa elabuwa changed the title Performance reports empty / data not saved to database Ensure performance timings are sent as integer values Nov 22, 2022
@sgiehl sgiehl added this to the 4.3.0 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants