Losing custom dimensions access when adding view rights

[mjschuurman]

Expected Behavior

When I add view right for Website Y to a user that has Admin rights to another website X then I expect the custom dimensions tab in the settings menu not to disappear. This also corresponde to the documentation at https://matomo.org/docs/custom-dimensions/
" They can be edited by anyone having at least ‘Write’ or ‘Admin’ access for a specific website."

Current Behavior

When I add view right for Website Y to a user that has Admin rights to another website X the custom dimension access rights are withdrawn.

Possible Solution

Implement the expected behavior.

Steps to Reproduce (for Bugs)

1. Create a user peterpan with only admin access to a single website X
2. Login as user peterpan and you can see after clicking the cogwheel the user has access to 'custom dimensions'
3. Add additional view rights for this user to another website Y
4. Login as user peterpan and click the cogwheel, you now see the 'custom dimensions' tab item is gone

Context

We want a user with admin rights for site X and view rights for site Y to still be able to add dimensions.

Your Environment

• Matomo Version: 4.8.0
• PHP Version: 8.0.15
• Server Operating System: Debian 11 (bullseye)
• Additionally installed plugins: Premium Bundle

• Browser: Chrome
• Operating System: Ubuntu

[sgiehl]

The menu entry is actually only visible if the current user has at least write access to the idSite given in the url parameters. So simply chaning the url parameter should show the menu again.
Nevertheless we should change the behaviour so the menu entry is visible as soon as the user has at least write access to any website.