Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist & restore widgets / reports settings, number of items to display, selected columns... #1915

Closed
anonymous-piwik-user opened this issue Dec 23, 2010 · 27 comments
Assignees
Milestone

Comments

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented Dec 23, 2010

We should record some settings and preferences in all reports.

List of settings to remember & restore:

  • of Rows to display (already saved for dashboard but not for other reports)

  • view type: table, goals table, pie chart, etc.
  • Selected metrics in graphs
  • "Cog" icon

Not MVP

  • In Goals report: remember which subreport was clicked in the bottom left selector (eg. websites VS custom var VS etc.)
@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 2, 2011

Currently, the dashboard remembers which "view types" you look at, and then restore it the next time you visit.

It would be interesting indeed to generalize the Dashboard setting save to all Piwik reports, ie. all Piwik reports would remember the last state they were in

  • view type: table, goals table, pie chart, etc.
  • exclude low population enabled/disabled

Maybe worth a different ticket, but exclude low filter should be based on the total of the datatable column itself, rather than visits, in case report is a subset (of page category, visitor plugins, etc.).

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Nov 25, 2011

  • Could also record the plotted columns last selected and restore them next time
    • Maybe for this we could add a "reset" button so that its easy to come back to "default" state in case they misclicked?
  • Also would be nice to record the selected report on the bottom left in Ecommerce, see original ticket at #2756
@sgiehl

This comment has been minimized.

Copy link
Member

@sgiehl sgiehl commented Feb 24, 2012

(In [5891]) refs #1915, fixes #2461 added new limitation select to all datatables. users can now select how many rows to display. limit changes to widgets on dashboard will automaticly be stored within layout and restored on reload. changed default limits to referer datatables to 25

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Feb 27, 2012

updated ticket description to include all settings to restore as per comments

@sgiehl

This comment has been minimized.

Copy link
Member

@sgiehl sgiehl commented Mar 10, 2012

(In [6027]) fixes #2979, refs #1915, refs #3011 completely refactored dashboard and widget javascripts (now using jquery plugins).
selected metrics in dashboard widgets are now stored in layout, too. also implemented some parts simplifying implementation of #3011 and #1915 and a small suggestion of #2461

@gka

This comment has been minimized.

Copy link
Contributor

@gka gka commented Jun 5, 2012

How can I use the persistent widget settings for my own widgets? Is there a generic JavaScript-API to store and recall widget-specific key-value pairs?

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Aug 21, 2012

Benaka what do you think is left on this ticket?

it would also be nice to have an JS api or function for core&plugins to use to record settings.

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Sep 8, 2012

It was also reported in: #3369 and request in the forums few times.

@anonymous-piwik-user

This comment has been minimized.

Copy link
Author

@anonymous-piwik-user anonymous-piwik-user commented Dec 9, 2013

Remembering these settings would make using Piwik a lot slicker and more user friendly. Please include it in a future edition!

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 10, 2014

This was also reported in #3469 Visits Overview (with graph) does not remember its status

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 10, 2014

It was reported in: #3807 Save and retrieve last zoom settings for maps

That we could also save & restore the map zoom. Is this a good idea (not sure)?

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 2, 2014

In 97f500f: refs #1915 a first version of persist & restore report settings. not everything is saved yet (such as metricsToPlot) but most things are

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 2, 2014

In ee2ec2b: refs #1915 reset viewDataTable parameters before each test run to remove previously persisted viewdatatable params from other test runs

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 2, 2014

In d509153: refs #1915 added missing method to delete all viewdatatableparams, metricsToPlot should be saved now as well

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 2, 2014

Regarding "In Goals report: remember which subreport was clicked in the bottom left selector (eg. websites VS custom var VS etc.)"

As this is not a viewDataTable / Visualization I won't implement this (for now)

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 2, 2014

In ce33725: refs #1915 trying to fix the installation tests

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 2, 2014

In 80d8d01: refs #1915 persist selected metrics and rows in referrers evolution

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 4, 2014

In d9512c6: refs #1915 clear a users saved parameters on delete, added some tests

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 4, 2014

In 2035f17: refs #1915 ignore filter_sort_order in change check after data requested

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 4, 2014

In ce76153: refs #1915 make sure the flat param is set in the url even if the value is 0. Otherwise there a persisted preference saying flat=1 might be preferred. By making sure the flat param is present in the url the persisted value will be overwritten

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 5, 2014

Closing this for now. We can create new tickets in case we want to persist more parameters/settings/...

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented May 6, 2014

Nice work Thomas, this will be a super useful feature to most piwik users.

If you're using Piwik and have any feedback about this feature, please comment here

@ksubileau

This comment has been minimized.

Copy link
Contributor

@ksubileau ksubileau commented May 8, 2014

And finally what about #3807 ? :D

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented May 9, 2014

@ksubileau good point, I've re-opened that ticket!

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented May 11, 2014

See follow up: #5143 Store and restore report settings for the anonymous user
refs #3110

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented May 14, 2014

See also: #5162: Remember detailed visitor log 'Rows to display'
(Visitor Log footer does not store settings)

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 19, 2014

In 1de1cdb: refs #1915 "columns" is added as a special query parameter in ViewDataTable class which results in having to do this. Problem: Switching to treemap visualization in eg PageUrls will save a columns "nb_hits" param, loading the normal view and sorting by column will result in only displaying nb_hits column instead of all columns. This seems to be the only case. If there are more we need to let the visualization decide which parameters to reset in case of a visualization change

@anonymous-piwik-user anonymous-piwik-user added this to the 2.2.1 - Piwik 2.2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…ings. not everything is saved yet (such as metricsToPlot) but most things are
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…run to remove previously persisted viewdatatable params from other test runs
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…params, metricsToPlot should be saved now as well
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…if the value is 0. Otherwise there a persisted preference saying flat=1 might be preferred. By making sure the flat param is present in the url the persisted value will be overwritten
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.