Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove again the "refresh" icon #19515

Closed
mattab opened this issue Jul 12, 2022 · 6 comments · Fixed by #19522
Closed

Remove again the "refresh" icon #19515

mattab opened this issue Jul 12, 2022 · 6 comments · Fixed by #19522
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but can't be reproduced (yet).

Comments

@mattab
Copy link
Member

mattab commented Jul 12, 2022

The goal of this issue is to revert the PR #19261 so that the Refresh icon is again removed.

We discussed quickly with @tsteur and agreed this icon creates clutter but doesn't really bring much value in the end. Most reports will never change unless they include today anyway. And the icon doesn't look good or consistent so it's just easier to remove it at this point.

This icon here and associated logic should be removed again:
image

@mattab mattab added Potential Bug Something that might be a bug, but can't be reproduced (yet). not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jul 12, 2022
@sgiehl
Copy link
Member

sgiehl commented Jul 12, 2022

@mattab That PR fixed an issue that was actually created by @tsteur (#11047). It might not look best and we maybe could improve that further, but I strongly dislike reverting PRs that were contributed by volunteers from the community. If that would have happened in the beginning of my contributions I might have stopped doing further contributions at all.

I strongly urge you and @tsteur to at least look through all the issues you had created in the past and close those you don't want to see implemented anymore. We should at least be able to trust that the tickets we create are reasonably up-to-date. Otherwise it is not only a waste of time for the person who invests his time to implement something, but also for us to review (and then revert something).

@mattab
Copy link
Member Author

mattab commented Jul 12, 2022

Sorry about the trouble here, and thanks for the feedback!

We'll try and review our created issues but realistically we don't have the time at the moment and for the next few months. In the meantime, we need to involve our UX expert and PM to assess early on, whether we want to do a given issue. They are the experts that know whether a given issue is still worth it or not. (and they can ask us questions to get our updated thoughts etc.)

In the meantime we do need to revert the change because we don't want to have this new icon forever in the app and it provides too little value and creates "UI noise" that is not helping our users.

@sgiehl
Copy link
Member

sgiehl commented Jul 13, 2022

@mattab In that case maybe we should leave somewhere a clear advice that people who want to work on an issue should first leave a note there, so you can decide if it makes sense to do so or not (if needed).

Btw. I don't think we need to fully revert #19261. It also added a keyboard shortcut to refresh the page. I guess we could at least keep that one, but only remove the icon?

@Findus23
Copy link
Member

I guess CONTRIBUTING.md would be a good location.

mattab added a commit to matomo-org/developer-documentation that referenced this issue Jul 14, 2022
… on it

to avoid risk a PR will not be merged due to changing priorities / product vision

refs matomo-org/matomo#19515 (comment)
@mattab
Copy link
Member Author

mattab commented Jul 14, 2022

@peterhashair
Copy link
Contributor

The refresh icon is removed, close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Potential Bug Something that might be a bug, but can't be reproduced (yet).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants