Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE: Segment translation for saveAndApply #19783

Closed
mindbreaker opened this issue Sep 28, 2022 · 3 comments
Closed

DE: Segment translation for saveAndApply #19783

mindbreaker opened this issue Sep 28, 2022 · 3 comments
Labels
Bug For errors / faults / flaws. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.12.0

Comments

@mindbreaker
Copy link
Contributor

Looks like the translation excapes the & in the button.
image
@mindbreaker mindbreaker added the Potential Bug Something that might be a bug, but can't be reproduced (yet). label Sep 28, 2022
@bx80
Copy link
Contributor

bx80 commented Sep 30, 2022

Thanks for reporting this @mindbreaker 👍

@bx80 bx80 added Bug For errors / faults / flaws. and removed Potential Bug Something that might be a bug, but can't be reproduced (yet). labels Sep 30, 2022
@bx80 bx80 added this to the For Prioritization milestone Sep 30, 2022
@sgiehl
Copy link
Member

sgiehl commented Oct 4, 2022

This has already been fixed with https://github.com/matomo-org/matomo/pull/19190/files#diff-05e5730fc6d27386e71d02ec01af30266f96593438ba2e504a8e900dccd0e0b5

@sgiehl sgiehl closed this as completed Oct 4, 2022
@sgiehl sgiehl modified the milestones: For Prioritization, 4.12.0 Oct 4, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 18, 2022
@mindbreaker
Copy link
Contributor Author

Thx:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.0
Development

No branches or pull requests
4 participants
@mindbreaker @justinvelluppillai @sgiehl @bx80