Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparklines in Ecommerce widget broken when using Comparison with Date Range #19933

Open
Starker3 opened this issue Nov 1, 2022 · 4 comments
Open
Labels
c: Ecommerce Ecommerce related improvements https://matomo.org/guide/reports/ecommerce/ Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@Starker3
Copy link
Contributor

Starker3 commented Nov 1, 2022

When Selecting a Date Range and comparing that Date Range with another preiod, the Ecommerce Widget sparklines show the incorrect values for the sparkline chart:
image

In the demo the issue is the same, but with the added issue that the sparklines are also flat:
image

To reproduce this:

  1. add the Ecommerce Overview widget to the Dashboard
  2. Select a Date Range and Select "Compare" to previous period
  3. Click on a metric that contains Revenue
    https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?period=range&date=2022-10-01,2022-11-01&category=Dashboard_Dashboard&subcategory=1&comparePeriods%5B%5D=range&compareDates%5B%5D=2022-08-30,2022-09-30
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but can't be reproduced (yet). label Nov 1, 2022
@peterhashair
Copy link
Contributor

@Starker3 thank you for reporting this, I can reproduce this on our demo or locally. I believe there is a regression there.

@peterhashair peterhashair added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Needs priority decision This issue may need to be added to the current milestone by Product Manager and removed Potential Bug Something that might be a bug, but can't be reproduced (yet). labels Nov 2, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Nov 2, 2022

It seems like when comparing, the revenue on the dataTable covert to string 'NZ$123' instead of float leading to a graphic loading error.

@sgiehl
Copy link
Member

sgiehl commented Nov 2, 2022

might be related to #15349

@Starker3
Copy link
Contributor Author

We have another email from a customer asking about this issue today.

@sgiehl sgiehl removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Feb 17, 2023
@sgiehl sgiehl added this to the For Prioritization milestone Feb 17, 2023
@michalkleiner michalkleiner added the c: Ecommerce Ecommerce related improvements https://matomo.org/guide/reports/ecommerce/ label Aug 28, 2023
@mattab mattab modified the milestones: For Prioritization, 5.6.0 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Ecommerce Ecommerce related improvements https://matomo.org/guide/reports/ecommerce/ Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

No branches or pull requests

5 participants