Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flat lines in Sparklines when comparing segments #19968

Closed
tsteur opened this issue Nov 8, 2022 · 2 comments · Fixed by #19971
Closed

Fix flat lines in Sparklines when comparing segments #19968

tsteur opened this issue Nov 8, 2022 · 2 comments · Fixed by #19971
Assignees
@sgiehl
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.12.4

Comments

@tsteur
Copy link
Member

tsteur commented Nov 8, 2022

see for example https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=week&date=2022-11-04&compareSegments%5B%5D=visitConvertedGoalId%3D%3D7&category=Goals_Goals&subcategory=General_Overview

and https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=week&date=2022-11-04&compareSegments%5B%5D=visitConvertedGoalId%3D%3D7&category=General_Visitors&subcategory=General_Overview

All sparklines don't show any data / only a flat line
image

I would assume this used to work.
@tsteur tsteur added the Potential Bug Something that might be a bug, but can't be reproduced (yet). label Nov 8, 2022
@peterhashair
Copy link
Contributor

peterhashair commented Nov 8, 2022 •
edited

I believe this could be a similar issue with #19933
#19967

Hey, @mattab Do we want to move this to the current milestone since is a regression and has an impact on usability?

@peterhashair peterhashair added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Needs priority decision This issue may need to be added to the current milestone by Product Manager and removed Potential Bug Something that might be a bug, but can't be reproduced (yet). labels Nov 8, 2022
@sgiehl
Copy link
Member

sgiehl commented Nov 8, 2022

Had a quick look into that. Seems like the date used for the sparklines is provided as range instead of a single day. That causes the sparkline to use the provided range, instead if looking back for last30. Will provide a PR to fix that.

@sgiehl sgiehl removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Nov 8, 2022
@sgiehl sgiehl added this to the 4.12.4 milestone Nov 8, 2022
@sgiehl sgiehl self-assigned this Nov 8, 2022
@sgiehl sgiehl mentioned this issue Nov 8, 2022
Merged
11 tasks
@elabuwa elabuwa changed the title Sparklines showing flat line when comparing segments Fix flat lines in Sparklines when comparing segments Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.12.4
Development

Successfully merging a pull request may close this issue.

Provide correct date parameter for comparison sparklines matomo-org/matomo
3 participants
@tsteur @sgiehl @peterhashair