Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation keys for the anomyization backend part #19985

Closed
Chardonneaur opened this issue Nov 10, 2022 · 3 comments · Fixed by #20330
Closed

Missing translation keys for the anomyization backend part #19985

Chardonneaur opened this issue Nov 10, 2022 · 3 comments · Fixed by #20330
Assignees
Labels
c: i18n For issues around internationalisation and localisation. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@Chardonneaur
Copy link

Hi guys,
When it comes to anonymize past data within the privacy part of the Matomo backend, there is no possibility to translate the keys within weblate.

@Chardonneaur Chardonneaur added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Nov 10, 2022
@sgiehl
Copy link
Member

sgiehl commented Nov 10, 2022

@Chardonneaur Do you mean the list of previous anonymizations? That one indeed seems to be hard coded.
Might be something we will fix with Matomo 5, as that part was meanwhile moved to vue here:
https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/PrivacyManager/vue/src/AnonymizeLogData/PreviousAnonymizations.vue

@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Nov 10, 2022
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 10, 2022
@Chardonneaur
Copy link
Author

@sgiehl whaoo, does it mean that all plugins will need to be refactored for Matomo v5?

@sgiehl
Copy link
Member

sgiehl commented Nov 13, 2022

If a plugin uses angular js, then yes. It needs to be rewritten. But that can already happen, as the last releases of Matomo 4 already have Vue included

@mattab mattab added the 5.0.0 label Jan 4, 2023
@sgiehl sgiehl self-assigned this Feb 7, 2023
@sgiehl sgiehl closed this as completed Feb 8, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants