Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid data sent in uadata array, causes complete tracking failure in Queued Tracking #20361

Closed
Starker3 opened this issue Feb 14, 2023 · 2 comments · Fixed by #20536
Closed
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@Starker3
Copy link
Contributor

We have a Matomo user who encountered an error a few days ago that caused their Queued Tracking queues to return errors, thereby not being able to process the queue and increase used memory to the point of alerts being sent.

When they investigated further they found that this error was being caused by invalid data being sent in the uadata array:

 'uadata' =>
array (
0 => '{}","?fa_vid',
1 => '{}"],"send_image":0}',
),

There are two issues that likely need to be addressed or investigated with this issue:

  1. We need to figure out how the invalid data was passed into the array
  2. Prevent such an issue from causing a tracking failure (Potentially by validating the data sent in the uadata array before processing it).

I've asked the user if they know what caused the initial invalid data in the array or for a URL that we can use to try and replicate this issue and will update this when I receive more information.

This seems like a similar issue to #20189

@Starker3 Starker3 added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Feb 14, 2023
@sgiehl
Copy link
Member

sgiehl commented Feb 15, 2023

@Starker3 I guess this is actually the same issue as here: matomo-org/plugin-QueuedTracking#194
We has applied some possible fixed around that, so would be good to know which version of Matomo and the plugin they are using.

@sgiehl sgiehl added Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Feb 15, 2023
@kgogolek
Copy link

I'm the customer who had this issue. Our Matomo version is 4.13.3 and Queued Tracking version was: QueuedTracking (v4.0.2). We should probably upgrade that but the issue was actually with the core component and was introduced by the addition of uadata and the fact that matomo throws an error if uadata is not json, which is easy to abuse on a analytics system with a public endpoint. What helped us is applying patches from this ticket to Tracker/Request.php
#20189

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. and removed Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Mar 31, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Mar 31, 2023
@sgiehl sgiehl self-assigned this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants