New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setCustomUrl() support for relative URLs #2198
Comments
I've only used setCustomUrl with an absolute url, e.g., use either or both setDocumentTitle() and setCustomUrl(); they are independent |
I found a number of links before I started to use setCustomUrl() manually and this confuses me... urls seems all to be shown in Piwik UI, but SiteSearch is not working...
My feeling is an absolute URL can be wrong in many situations. For example I'm using subdomains. From SiteSearch maintainer feedback, he is using the site URLs to find an URL and this can be wrong if I'm using a siteID on many sites. But I'm only guessing here if this could be a problem or not... |
Mixing domains and absolute/relative paths will mash the results, e.g.,
Under Actions | Pages, we see '/A' at the first level. The nested entries are:
In the last row, the 'A' is downcased and a link is created -- both transformations are arguably wrong. |
Is it really a bug now or is it by design and it only need to be documented in the API documentation that the URL inside setCustomUrl() need to be absolute? |
In 1.2.1, it needs to be absolute. Going forward, I think we should support relative URIs. I'm going to open another ticket for the UI inconsistencies in Actions | Pages. |
(In [4143]) fixes #2198 - thanks for raising this hass. Limitations:
|
I'm using setCustomUrl() to fire a friendly URL from Drupal module into Piwik database for SiteSearch, but I still have issues and it's not working. I'd like to make sure that I'm doing everything correctly and the documentation of setCustomUrl() is not clear to me.
Can someone please explain me if the URL need to be absolute or relative and if relative is also possible if the leading slash may need to be removed?
Can you confirm if the following would be correct or what is incorrect, please?
I'd also need to know if setDocumentTitle():
can be used together with setCustomUrl():
or if need to expect issues if both are used together.
THX!
The text was updated successfully, but these errors were encountered: