Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group all Google search SSL unknown keywords under "Keyword not defined" #2718

Closed
mattab opened this Issue Oct 18, 2011 · 9 comments

Comments

Projects
None yet
2 participants
@mattab
Copy link
Member

mattab commented Oct 18, 2011

See Piwik Keyword not defined FAQ

See google announcement

We should make sure that the "search engine" appears as google still, but keyword would appear as "Keyword not provided"

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Oct 22, 2011

Apparently it is not standard SSL behavior, they somehow still pass the referrer but with empty &q= query parameter.

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Oct 22, 2011

In the log_visit DB, I suggest that the referer_name be "google" and referer_keyword be empty string. During archiving, the datatable label would be a constant KEYWORD_NOT_PROVIDED. Then, this will be replaced in an API filter with the localized string eg. "Keyword not provided" in english.

@robocoder

This comment has been minimized.

Copy link
Contributor

robocoder commented Oct 22, 2011

For the detection logic:

  • no referrer - track as a search engine with empty keyword
  • a referrer with specified query parameter but empty is also a search engine with empty keyword
  • where the keyword is non-empty, track as search engine with non-empty keyword
  • where the keyword detection fails, track as external website
@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Oct 24, 2011

Replying to vipsoft:

For the detection logic:

  • no referrer - track as a search engine with empty keyword

No referrer == Direct entry, not search engine :)

Otherwise OK!

@robocoder

This comment has been minimized.

Copy link
Contributor

robocoder commented Nov 14, 2011

What about the case where the referrer is just http://domain.tld

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Dec 23, 2011

(In [5604]) Fixes #2718

  • Only fixes for Google for now, we can generalize the code later when other search engines start doing the same
  • Marking hidden keywords as "Keyword not defined"
  • Linking the keyword to the new FAQ: Piwik Keyword not defined
@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Feb 4, 2012

(In [5756]) Refs #2718

  • do not display "Your top converting keywords are: 'Keyword not defined'" because it is very irritating!
@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Feb 11, 2012

(In [5800]) Refs #2718

  • Do not display "Keyword not defined" in the widget showing top keywords per page

@mattab mattab added this to the 1.7 Piwik 1.7 milestone Jul 8, 2014

@mattab

This comment has been minimized.

Copy link
Member Author

mattab commented Mar 14, 2017

Good news: you can now use our new Search Engine Keywords Performance plugin which lets you import your Google, Bing and Yahoo keywords into your Piwik. Learn more about the reports provided and how to import keywords on the plugin page and in the Search Keywords Monitor User Guide.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.