Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If mysql user does not have sufficient privileges, Piwik install fails "website time zone is not valid" #2963

Closed
mattab opened this issue Feb 22, 2012 · 6 comments
Labels
Bug Major
Milestone

Comments

@mattab
Copy link
Member

@mattab mattab commented Feb 22, 2012

Reported in forum:

Rather than failing with error message "timezone not valid"

  • we should display a proper error message "User does not have privilege"
  • update the requirement documentation to detail which privileges are required

Problem in code:

This issue arises from a call to Piwik_SetOption (when it's called from setDefaultTimezone) that causes an exception to be thrown because the public function "set" in Option.php fails at it's database call. This is due to insufficient database user privileges. Granting the piwik DB user more privileges allows the setup to continue.

Maybe we could have a page that checks the database user grants before continuing the setup. Or at-least some docs on the needed permissions for the piwik DB user since not everyone will be doing a "grant all".

@robocoder
Copy link
Contributor

@robocoder robocoder commented Feb 27, 2012

Checking the privileges by looking at SHOW GRANTS, or mysql.user and mysql.db tables, is non-trivial.

It would probably be easier (and more database-agnostic) to explicitly test the various operations used by Piwik, e.g.,

  • CREATE/ALTER, SELECT, INSERT, UPDATE, DELETE, etc

@diosmosis
Copy link
Member

@diosmosis diosmosis commented May 17, 2012

Attachment: Patch for this issue.
2963.diff.tar.gz

@diosmosis
Copy link
Member

@diosmosis diosmosis commented May 17, 2012

I uploaded a patch for this issue. This is the first time I've looked at the installation code, so I believe it would be good to review them.

Notes on the patch:

  • I use the strategy @vipsoft mentioned.
  • The check is provided as an extra form validation for the database setup page. If the user doesn't have the right privileges, a message displaying all the required privileges is displayed. As far as I can tell, its not possible to make a validation error message depend on the form values themselves, so that's as specific as it gets.

Let me know what you think.

@mattab
Copy link
Member Author

@mattab mattab commented May 24, 2012

Thanks vipsoft for the suggestion, and Kuddos capedfuzz for this clean patch!
Code review:

  • I would maybe detail the error a bit more in Installation_InsufficientPrivileges maybe you can add something along the lines of "You can use a tool such as phpMyAdmin (or a SQL query). If you do not know what this means, please ask your sysadmin to grant these privileges to the %s user".
  • TEST_TABLE_NAME and TEST_TEMP_TABLE_NAME couild be "piwik_test_table_tmp" and "piwik_test_table" just in case they're somehow left in there
  • can you confirm you checked individually each missing right and that the code works in all the cases? (I'm thinking in particular if the error codes in isAccessDenied() would cover all use cases of missing permissions)

@diosmosis
Copy link
Member

@diosmosis diosmosis commented May 29, 2012

(In [6371]) Fixes #2963, added installation check for needed DB user privileges.

@diosmosis
Copy link
Member

@diosmosis diosmosis commented May 29, 2012

Regarding my commit: I tested w/ every privilege, every needed privilege, w/ every needed privilege except one (for each privilege), and w/ no privileges. Also tested to make sure other fields were checked properly. Everything worked.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Major
Projects
None yet
Development

No branches or pull requests

3 participants