Show a warning banner to notify when tracker's record_statistics is not enabled

[anonymous-matomo-user]

It can happen to the best of us, either because of forgetfulness or because piwik somehow reordered the contents of config.ini.php (I'm not 100% sure it is possible, but it seemed to happen to me recently, and I wrongly assumed that the line I had added to the top of the file had been simply removed by piwik... leading to weeks of lost statistics).

If this is present in the configuration:

[Tracker]
record_statistics = 0

...simply tell the user. There are a couple of ways to do so, which are not mutually exclusive:

• After running the upgrade script (from the commandline or the web UI)
• When inside the piwik's admin settings, or even directly in the main web interface, as a banner/infobar at the top above (or below) the dashboard menu

In the web UI, not only could we show the warning message, but it could also contain a button tracking, if such a thing is easy and safe to do.
Keywords: usability

[halfdan]

I believe it is enough to show the warning message in the admin menu (and only for the superadmin, since he is the only one who likely has access to the config).

[mattab]

Agreed!

[anonymous-matomo-user]

In 84a2e9e: Warning is now shown on General Settings page to warn user
when tracking is disabled via record_statistics = 0.

fixes #3551

[mattab]

In 8ac1bc2: Refs #3551 Display message in all admin controlllers