Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Parameter 'cid' Custom Visitor ID, should be "enforced" when it is specified #3776

Closed
anonymous-matomo-user opened this issue Feb 25, 2013 · 10 comments
Assignees
Labels
Bug For errors / faults / flaws.
Milestone

Comments

@anonymous-matomo-user
Copy link

anonymous-matomo-user commented Feb 25, 2013

In order to set a custom visitor Id, the parameter cid is used in PiwikTracker.php (see [https://github.com/piwik/piwik/blob/ce63a9fbc4727df77a351fc55a641693d10a4f5c/libs/PiwikTracker/PiwikTracker.php#L1047]). However, it cannot be used to distinguish Visitors as distinct.

Steps to reproduce:

The visitor is known (idvisitor = fbface7fb484cf60,
                            config_id = 6da98b12e33904b4,
                            idvisit = 1270,

(Complete output attached)

Also, cid is not documented in the FAQ [http://piwik.org/docs/tracking-api/reference/].

May be related: #3312

@anonymous-matomo-user
Copy link
Author

anonymous-matomo-user commented Feb 25, 2013

Attachment: Tracking Debug Output
piwik.html

@anonymous-matomo-user
Copy link
Author

anonymous-matomo-user commented Feb 25, 2013

Attachment: Visitor Log: Only one visit (instead of several), wrong visitor id
crushed.png

@anonymous-matomo-user
Copy link
Author

anonymous-matomo-user commented Feb 25, 2013

Using Piwik 1.10.1 . API key is admin user of idsite(2).

@anonymous-matomo-user
Copy link
Author

anonymous-matomo-user commented Feb 25, 2013

Oh, sorry: auth_token should be token_auth, of course. Attached a new version of the output, as the problem remains:

Matching visitors with: visitorId=1234567890123456 OR configId=6da98b12e33904b4<br />
The visitor is known (idvisitor = bb0ccf88648b5ee2,
...

In case of a forced (vs. indicated via _id) visitorId it should only match by visitorId.

@anonymous-matomo-user
Copy link
Author

anonymous-matomo-user commented Feb 25, 2013

Attachment: 2nd test output
test.html

@anonymous-matomo-user
Copy link
Author

anonymous-matomo-user commented Feb 25, 2013

I've sent a pull request on github: #35 - which fixed the issue for me.

@mattab
Copy link
Member

mattab commented Mar 3, 2013

Thanks for the report, very nice find. I agree with your proposal, that when a user has called $tracker->setVisitorId( ) and has authenticated with token_auth, then the visitor ID should be enforced.

@mattab
Copy link
Member

mattab commented Mar 3, 2013

In 12c3fbe: Fixes #3776, Fixes #3787

Adding integration test to test this code.

I also updated tracking api reference to explain "cid" parameter.

cid (requires token_auth to be set) defines the visitor ID for this request. You must set this value to exactly a 16 character hexadecimal string (containing only characters 01234567890abcdefABCDEF). When specified, the Visitor ID will be enforced. This means that if there is no recent visit with this visitor ID, a new one will be created. If a visit is found in the last 30 minutes with your specified Visitor Id, then the new action will be recorded to this existing visit.

@mattab
Copy link
Member

mattab commented Mar 3, 2013

Tracking API updated

@mattab
Copy link
Member

mattab commented Sep 8, 2014

see also #6109

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws.
Projects
None yet
Development

No branches or pull requests

2 participants