Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ExampleUI plugin with latest widget APIs #3994

Closed
mattab opened this issue Jun 7, 2013 · 16 comments
Closed

Update ExampleUI plugin with latest widget APIs #3994

mattab opened this issue Jun 7, 2013 · 16 comments
Assignees
@tsteur
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Jun 7, 2013

ExampleUI plugin is a nice tool, we should update it to work with latest widget API (and fix the bar graph which does not display)

In general, does this plugin make it clear to developers what Piwik Framework offers in terms of using the framework to display custom data?

See also: #4124 Display a custom date-based dataset in a simple Piwik Plugin
@mattab
Copy link
Member Author

mattab commented Jun 7, 2013

see http://forum.piwik.org/read.php?2,104264,page=1#msg-104316

@tsteur
Copy link
Member

tsteur commented Oct 2, 2013

In 2294b38: refs #3994 coding style, removed unused code

@tsteur
Copy link
Member

tsteur commented Oct 2, 2013

In 7eb6a2b: refs #3994 do not display metric visits and actions

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In f689733: refs #3994 evolution graph failed to load if DataTable object is given

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In 11d2794: refs #3994 added example for evolution graph

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In 896d110: refs #3994 this fixes percentage values are always 0 in pie graphs

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In 852513d: refs #3994 fix the evolution graph is sorted by value if only one metric is selected

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

I think this is done. Any other ideas?

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In a963a87: refs #3994 allow only one metric

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In 955ef7c: refs #3994 this is an example how to make a customized existing visualization reusable

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In c730967: refs #3994 gives some autocompletion to viewdatatable properties

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In 5c30547: refs #3994 auto completion for visualization properties

@tsteur
Copy link
Member

tsteur commented Oct 3, 2013

In ec6de8c: refs #3994 use table as default type

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

Feedback:

  • nice changes!
  • add Column documentation for the "Temperature in C" column (on hover)
  • in Tag Clouds menu, there is a " Previous " link display but shouldn't be
  • Limit selector does not work on Evolution Graph (error is "The parameter 'columns' isn't set in the Request, and a default value wasn't provided.")
  • CustomDataTable should be called CustomViewDataTable maybe? or maybe CustomDataTableView?

@tsteur
Copy link
Member

tsteur commented Oct 21, 2013

In 6a3d27b: refs #3994 do not create a separate class for this example

@tsteur
Copy link
Member

tsteur commented Oct 21, 2013

In 2192359: refs #3994 added dummy documentation for temperature metric

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 coding style, removed unused code
2294b38
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 do not display metric visits and actions
7eb6a2b
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 evolution graph failed to load if DataTable obje…
f689733 
…ct is given
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 added example for evolution graph
11d2794
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 this fixes percentage values are always 0 in pie…
896d110 
… graphs
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 fix the evolution graph is sorted by value if on…
852513d 
…ly one metric is selected
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 allow only one metric
a963a87
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 this is an example how to make a customized exis…
955ef7c 
…ting visualization reusable
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 gives some autocompletion to viewdatatable prope…
c730967 
…rties
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 auto completion for visualization properties
5c30547
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 use table as default type
ec6de8c
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 do not create a separate class for this example
6a3d27b
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#3994 added dummy documentation for temperature metric
2192359
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@tsteur @mattab