Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment Editor should work to list segments in IE8 #4012

Closed
BeezyT opened this issue Jun 17, 2013 · 5 comments
Closed

Segment Editor should work to list segments in IE8 #4012

BeezyT opened this issue Jun 17, 2013 · 5 comments
Labels
Bug For errors / faults / flaws.
Milestone
2.0

Comments

@BeezyT
Copy link
Member

BeezyT commented Jun 17, 2013

The Segmen Editor/Selector doesn't work in IE8.

In fact, it throws an error and causes JS to crash, so Piwik is not usable anymore when the Segment Editor is enabled.

This ticket contains fixes and is a place for discussion whether we want to support IE8 at all.
@BeezyT
Copy link
Member Author

BeezyT commented Jun 17, 2013

In 84fb1bf (which i committed by accident with the wrong message), the main problems are fixed. JS does not crash anymore and Piwik can be used.

@BeezyT
Copy link
Member Author

BeezyT commented Jun 17, 2013

In c27a972: refs #4012 fixing two more for-in loops for ie8

@BeezyT
Copy link
Member Author

BeezyT commented Jun 17, 2013

The Segment Selector works now.

Editing Segments seems like it would be a lot of work to adapt to IE8.

@mattab
Copy link
Member

mattab commented Jun 18, 2013

Very nice that at least the selector works!

@mattab
Copy link
Member

mattab commented Sep 16, 2013

Moving 1.x closed tickets to 2.0

@BeezyT BeezyT added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@BeezyT @mattab