Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate our templating engine from Smarty to Twig #4019

Closed
mattab opened this issue Jun 24, 2013 · 28 comments
Closed

Migrate our templating engine from Smarty to Twig #4019

mattab opened this issue Jun 24, 2013 · 28 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jun 24, 2013

Smarty was nice, but now Twig is the real deal, and we would love to migrate to Twig.

As part of Piwik 2.0, as we increase the minimum PHP version to 5.3, we can now use Twig.

Thanks to the amazing work by @halfdan this is becoming a reality!

@mattab
Copy link
Member Author

mattab commented Jun 24, 2013

In 0ddd15a: Removing final |raw from codebase
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 7bbf305: Reverting my commit where I removed all |raw per @halfdan feedback
Instead we should manually add the missing |raw...
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 5aa8081: adding more |raw
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 4d57c02: adding more |raw
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 6ac63c2: * Fixing SitesManager page

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 4487ee6: * Fixing Users manager
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 0232067: * Fixing Users manager
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 99fa74d: * Fixing over escaping
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 25, 2013

In 8f6d151: * Adding htaccess to allow loading SVG+PNG logos on Settings page
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 26, 2013

In 12e81ae: * admin screens,

@mattab
Copy link
Member Author

mattab commented Jun 26, 2013

In b8b0269: * Some more fixes
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 26, 2013

In 97149fb: * Visitor log page tooltips
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 26, 2013

In 62bba50: * Fixing overlay
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 26, 2013

In 55f2efd: * Live
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 27, 2013

In b814322: Removing Smarty strings from codebase, fixing install
Adding twig to LEGALNOTICE
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 28, 2013

In 60e3b96: * removing most mentions to "tpl"
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jun 28, 2013

In a62f1c1: * Converting CLI templates to twig

@mattab
Copy link
Member Author

mattab commented Jun 28, 2013

In 6aee04b: * Fix concats
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 6355922: * Fix the SEO widget
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In affa786: * Removing |count as I didn't notice |length was already used
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 63aa1de: * Cell used to be "spaceless" so restoring, just in case this could cause hidden regression...
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 28b9f12: * During the big merge I noticed some code was duplicated in userCountry.js
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 84bf3a5: * themes or plugins should not have the php requirement in JSON, it should only be in "Piwik installation check".
... unless some non-core plugins would indeed require more recent than 5.3 (but core plugins will always work if Piwik was successfully installed)
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 9168480: * Enabling Twig 'strict_variables' so that we write best code possible, and learn early if some tpl code is not valid. Fixing few bugs that this uncovered

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 7bae344: * Restoring the cache buster output filter which was lost at some point
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 00ef553: * Enabling templates compiled cache. @halfdan, was there any reason it was disabled?
Refs #4019

@mattab
Copy link
Member Author

mattab commented Jul 1, 2013

In 1b35b77: * Fixing some missing |raw using global search {{.<{1,}.}}
Refs #4019

@mattab
Copy link
Member Author

mattab commented Aug 9, 2013

Twig support is now fully working. awesome!

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Instead we should manually add the missing |raw...
Refs matomo-org#4019
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
 * Enabling debug on twig so we can use {{ dump(var) }} function
Refs matomo-org#4019
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
 * removed the remains of CDN/jquery feature
Refs matomo-org#4019
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
* deprecating View::factory, simplify constructor
Refs matomo-org#4019
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…hould only be in "Piwik installation check".

... unless some non-core plugins would indeed require more recent than 5.3 (but core plugins will always work if Piwik was successfully installed)
Refs matomo-org#4019
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…e, and learn early if some tpl code is not valid. Fixing few bugs that this uncovered

* refactoring the percent column label in getPercentVisitColumn()
* removing indexBeforeMenu and putting directly in parent template
Refs matomo-org#4019
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants