-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate our templating engine from Smarty to Twig #4019
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
Comments
In 6ac63c2: * Fixing SitesManager page
|
In 12e81ae: * admin screens,
|
In a62f1c1: * Converting CLI templates to twig
|
In 9168480: * Enabling Twig 'strict_variables' so that we write best code possible, and learn early if some tpl code is not valid. Fixing few bugs that this uncovered
|
Twig support is now fully working. awesome! |
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
Instead we should manually add the missing |raw... Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
* Enabling debug on twig so we can use {{ dump(var) }} function Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
* removed the remains of CDN/jquery feature Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
Adding twig to LEGALNOTICE Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
* deprecating View::factory, simplify constructor Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…ause hidden regression... Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…hould only be in "Piwik installation check". ... unless some non-core plugins would indeed require more recent than 5.3 (but core plugins will always work if Piwik was successfully installed) Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…e, and learn early if some tpl code is not valid. Fixing few bugs that this uncovered * refactoring the percent column label in getPercentVisitColumn() * removing indexBeforeMenu and putting directly in parent template Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…t was disabled? Refs matomo-org#4019
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Major
Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Smarty was nice, but now Twig is the real deal, and we would love to migrate to Twig.
As part of Piwik 2.0, as we increase the minimum PHP version to 5.3, we can now use Twig.
Thanks to the amazing work by @halfdan this is becoming a reality!
The text was updated successfully, but these errors were encountered: