Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to define new Visualizations and custom ViewDataTable #4041

Closed
diosmosis opened this issue Jul 8, 2013 · 88 comments
Closed

Allow plugins to define new Visualizations and custom ViewDataTable #4041

diosmosis opened this issue Jul 8, 2013 · 88 comments
Assignees
@tsteur
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.0

Comments

@diosmosis
Copy link
Member

This ticket includes any refactoring to be done to ViewDataTable & Piwik_Visualization and will include a new treemap visualization.

The goal is to move all visualizations and Viewdatatable to a new CoreVisualizations plugin.

This ticket is a rather large refactoring and team work among Piwik team members!
@anonymous-matomo-user
Copy link

In b5ed458: Refs #4041, cleaned up ViewDataTable, related classes, and related templates:

  • Remove uniqIdTable, chartDivId and related code as important element IDs are determined in datatable_manager.js now.
  • Clarify _dataTable twig template + related css.
  • Also added visiblity to Piwik_DataTable_Renderer_Php::renderException.

@anonymous-matomo-user
Copy link

In 4f0e655: Refs #4041, allow subtable template to be used if idSubtable is in request so Actions controller doesn't have to call setTemplate. Also did some mild refactoring for Piwik_ViewDataTable_HtmlTable::setRecursiveLoadDataTableIfSearchingForPattern.

@anonymous-matomo-user
Copy link

In a7879ae: Refs #4041, removed Piwik_ViewDataTable_HtmlTable::recursiveDataTableLoad.

@anonymous-matomo-user
Copy link

In 22d7676: Refs #4041, removed extra ViewDataTable classes used by Goals Controller.

@anonymous-matomo-user
Copy link

In c792ca8: Refs #4041, make getVisitorLog.twig more like _dataTable.twig.

@anonymous-matomo-user
Copy link

In 98e6c9b: Refs #4041, fix widgetize datatable width regression.

@anonymous-matomo-user
Copy link

In 0105777: Refs #4040, #4041, move all ViewDataTable properties to the viewProperties array and allow these properties to be specified through new display metadata. Converted the Actions, Goals, UserSettings and VisitTime controllers.

Notes:

  • Includes refactoring of ExcludeLowPopulation filter.

@anonymous-matomo-user
Copy link

In 349f280: Refs #4041, fix bug in displaying DBStats reports by redefining how columns_to_display view property defaults and allow unique visitors to be displayed on reports that have it, outside of period=day.

@anonymous-matomo-user
Copy link

In 0713062: Refs #4041, move Piwik_ViewDataTable_GenerateGraphData logic to new JqplotDataGenerator class that does not derive from ViewDataTable and remove recursive API request used to get graph data.

@anonymous-matomo-user
Copy link

In 93b301d: Refs #4041, modify tag cloud ViewDataTable to use _dataTable.twig w/ Visualization_Cloud as visualization..

@anonymous-matomo-user
Copy link

In 26051fc: Refs #4041, merge _dataTableGraph.twig with _dataTable.twig (moved unmergable parts to new visualization twig file for Visualization_JqplotGraph).

@anonymous-matomo-user
Copy link

In edf2c04: Refs #4040, #4041, added ability to access view properties directly, started documenting view properties and modified ExampleUI plugin to set view properties directly.

@anonymous-matomo-user
Copy link

In 0ea1a94: Refs #4040, #4041 convert RowEvolution popup rendering code to set view properties directly.

@anonymous-matomo-user
Copy link

In 13f657c: Refs #4040, #4041, fix sparklines regression caused by datatable css refactoring and clean up the getLastUnitGraphAcrossPlugins function (modified to set properties directly).

@anonymous-matomo-user
Copy link

In 0f61caa: Refs #4040, #4041 removed rest of viewdatatable set/get/enable/disable property functions, did the same for all other ViewDataTable classes, moved most of ViewDataTable/HtmlTable logic to visualization instead of main class and re-add links for UI integration tests.

@anonymous-matomo-user
Copy link

In 883c322: Refs #4040, #4041, move more logic out of HtmlTable ViewDataTable class.

@anonymous-matomo-user
Copy link

In 1a9898b: Refs #4040, #4041, fix regression in default sort column of goals table.

@anonymous-matomo-user
Copy link

In 7519e67: Refs #4040, #4041, move AllColumns ViewDataTable & Goals ViewDataTable logic to HtmlTable visualization class & remove those classes. Revised the way visualizations default/override view properties. Cleaned up the ViewDataTable class a bit. Added base type for datatable visualizations.

@anonymous-matomo-user
Copy link

In b808489: Refs #4040, #4041, remove is_multi_evolution javascript parameter as it is no longer necessary due to earlier row evolution refactoring.

@anonymous-matomo-user
Copy link

In cc92fac: Refs #4040, #4041, remove GenerateGraphHtml & descended ViewDataTables and replace w/ new visualizations for jqplot.

@anonymous-matomo-user
Copy link

In ac3a25c: Refs #4040, #4041, forgot to remove GenerateGraphHTML file.

@anonymous-matomo-user
Copy link

In cf8d0a5: Refs #4041, #4040, moved viewdatatable cloud logic to cloud visualization. Removed cloud viewdatatable.

@anonymous-matomo-user
Copy link

In 2615404: Refs #4040, #4041, move visualization only view properties to separate visualizations, changed JavaScript properties to 'client side parameters' and 'overridable properties' to 'client side properties', changed keep_summary_row from a JavaScript property to a client side property, allowed visualization properties to be inherited, fixed system that allowed visualizations to set custom defaults for property values, modified behavior of datatable_css_class viewdatatable property, allow view properties to be customized in metadata based on the visualization used, and tweaks to UI Integration tests.

@anonymous-matomo-user
Copy link

In 9b5a42a: Refs #4040, #4041, change the way jqplot.js checks for viewdatatble types, changed relatedReports view property name to related_reports and fixed spelling of row_picker_mach_rows_by.

@anonymous-matomo-user
Copy link

In e898bc2: Refs #4040, #4041 add initial code for making datatable visualizations an extensibility point.

@anonymous-matomo-user
Copy link

In 9e19f24: Refs #4041, #4040 add new CoreVisualizations plugin and move HtmlTable, Cloud & JqplotGraph visualizations to it and improve UIIntegration test debug output.

@anonymous-matomo-user
Copy link

In be35dc4: Refs #4040, #4041, removed ViewDataTable::init & moved default property values for core properties to Properties class.

@anonymous-matomo-user
Copy link

In 7daadd4: Refs #4040, #4041 added new plugin ExtraVisualizations with dummy visualization and made it possible for non-core visualizations to appear in DataTable UI footer.

@anonymous-matomo-user
Copy link

In 6f8b40d: Refs #4040, #4041, added documentation to DataTableVisualization class.

@anonymous-matomo-user
Copy link

In 27dcd70: Refs #4040, #4041, removed two-phase rendering for ViewDataTable.

sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4077, matomo-org#4041, separated jqplot specific code…
fcb5892 
… from generic series picker code and cleaned up series picker code a bit.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, matomo-org#4077, document SeriesPicker JS class.
f1193c9
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4100, matomo-org#4041, matomo-org#4077, add minimal U…
ed0f3d2 
…I module inclusion/creation function and use for SeriesPicker. Also includes a documentation correction for SeriesPicker.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4100, matomo-org#4041, matomo-org#4077, fix docs in l…
6aa3a44 
…ast commit.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, fix bug in defaulting selectable columns.
c4b42a1
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, document some functions in Graph visualization …
6cb518d 
…class.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, refactored jqplot datatable visualizations (mai…
53f3d24 
…nly the evolution graph),

Notes:
  - Fix bugs in DataTable class where getRowFromLabel would fail if summary row label is returned.
  - Fix regression caused by datatable visualization refactor (add_total_row property was effectively ignored).
  - Added x_axis_step_size property to jqplot graph.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, small tweak to last commit.
b674102
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, refactored jqplot.js file by removing JQPlot cl…
42623a0 
…ass and creating JqplotGraph datatable class, and did more refactoring to jqplot data generating mechanism.

Notes:
  - Removed jqplot specific code from datatable_manager.js and moved to new JqplotGraph class.
  - Moved tooltip percentage calculating code to client.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, split JqplotGraph datatable class into three: J…
7c3d534 
…qplotBarGraph, JqplotPieGraph & JqplotEvolutionGraph.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, add last visits graph to visitor profile (comme…
09784e5 
…nted out) and highlight visit whose details are currently displayed.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, moved & renamed actionDataTable JavaScript clas…
3c11c23 
…s to file in the Actions plugin.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, force DataTable visualizations to specify which…
b1205a5 
… properties should be overridable and move some view properties to different visualizations.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, default to HtmlTable if visualization ID is inv…
e36142a 
…alid and filled out a function doc.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, Fix regression.
6452d59
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, use require() and UIControl in all DataTable JS…
d5d6c9e 
… classes.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, matomo-org#3317, matomo-org#4077, allow differe…
83261e0 
…nt visualizations to specify their own loading logic (when the appropriate footer icon is clicked) and fix a couple UI bugs in treemap.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, remove subtable_template property and _dataTabl…
4bb2de9 
…eActions_subDataTable.twig file.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, matomo-org#3317, allow visualization ID to be w…
c0768bf 
…hole class name, allow footer icons to be customized per report/visualization, made visitor log a new visualization and removed the datatable_template display property.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, add default value to all visualization property…
e4c5269 
… docs.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, make all DataTableVisualizations derive from Pi…
6b906ed 
…wik\View.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, fix regression in tag cloud.
ce27579
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, rename javascriptVariablesToSet to clientSidePa…
c9356bb 
…rameters and fix regression in visitor log.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, allow datatable HTML to use JS namespace when s…
2b14ad2 
…pecifying the client-side datatable type.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, remove DatatableManager class and replace with …
4d5d101 
…UIControl code.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, fix bug when switching to normal visualizations.
4d7d126
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, matomo-org#4077, make sure treemap subtable loa…
ed569f2 
…ding determines row limit dynamically, and allow visualizations to apply viewdatatable queued filters on their own time.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4077, matomo-org#4041, resize treemap on widget resiz…
c2061d4 
…e and fix regression in jqplot refactoring (export as image didn't work).
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, fix bug where columns query parameter was not c…
b7bfa2b 
…orrectly overriding default value of columns_to_display display property.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4041, fixing DBStats regression.
957b80e
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@diosmosis @tsteur @mattab @anonymous-matomo-user