Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert core and plugin translations to simple json format #4086

Closed
halfdan opened this issue Aug 16, 2013 · 9 comments
Closed

Convert core and plugin translations to simple json format #4086

halfdan opened this issue Aug 16, 2013 · 9 comments
Assignees
@halfdan
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
2.0

Comments

@halfdan
Copy link
Member

halfdan commented Aug 16, 2013

As discussed during the meetup, we want to move translation files away from PHP arrays and use json files instead.
@anonymous-matomo-user
Copy link

In ba58259: Converted PHP translations to nested JSON

refs #4086

@anonymous-matomo-user
Copy link

In 058c83e: Adjust Piwik_Translate function to handle nested translation array
Adjust Translate class to properly load .json translation into array
Adjust JavaScript translation filter
Adjust plugins manager to load plugin translations properly

refs #4086

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2013

In 740854c: refs #4086 removed trailing/leading whitespaces from english translations

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2013

In 5dba66b: refs #4086 fixed translationwriter to work with json files

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2013

In 4be8840: refs #4086 fixed languagesmanager tests;
now thirdparty translations will be removed

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2013

In 8e1a4f0: refs #4086 adjusted automatic updatescript to work with new json format

@sgiehl
Copy link
Member

sgiehl commented Aug 19, 2013

In 5690a76: refs #4086 updated language files; third party plugins were removed

@anonymous-matomo-user
Copy link

In 0499b17: Downgrade json_encode to 5.3 for now (ommit JSON_UNESCAPED_UNICODE and JSON_PRETTY_PRINT)
Adjust TranslationWriterTest

fixes #4086

@anonymous-matomo-user
Copy link

In 42893f5: Fixes failing tests for non-translated translation keys. Thanks to @tsteur for spotting this!

refs #4086

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@halfdan halfdan self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Converted PHP translations to nested JSON
ba58259 
refs matomo-org#4086
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Adjust Piwik_Translate function to handle nested translation array
058c83e 
Adjust Translate class to properly load .json translation into array
Adjust JavaScript translation filter
Adjust plugins manager to load plugin translations properly

refs matomo-org#4086
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4086 removed trailing/leading whitespaces from englis…
740854c 
…h translations
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4086 fixed translationwriter to work with json files
5dba66b
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4086 fixed languagesmanager tests;
4be8840 
now thirdparty translations will be removed
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4086 adjusted automatic updatescript to work with new…
8e1a4f0 
… json format
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4086 updated language files; third party plugins were…
5690a76 
… removed
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Downgrade json_encode to 5.3 for now (ommit JSON_UNESCAPED_UNICODE an…
0499b17 
…d JSON_PRETTY_PRINT)

Adjust TranslationWriterTest

fixes matomo-org#4086
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Fixes failing tests for non-translated translation keys. Thanks to @t…
42893f5 
…steur for spotting this!

refs matomo-org#4086
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halfdan halfdan

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@halfdan @sgiehl @anonymous-matomo-user