-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set first party client cookies from PiwikTracker.php to improve dual JS-PHP tracking and data accuracy #4239
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
Comments
In 0d5a61f: Adding first party cookie read/write to the PiwikTracker PHP client. Refs #4239 |
In 0f2af69: Refs #4239 Fixing bug and adding custom variables cookie setter TODO: we need some tests to make sure this works as expected and will not be broken in the future
|
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…Refs matomo-org#4239 Based off the pulll request by @claytondaley and tidied up matomo-org#114
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
…tter TODO: we need some tests to make sure this works as expected and will not be broken in the future * Test new visit without a cookie: cookies 'ses' and 'id' should be created, * Test new page view: the 'ses' cookie should be deleted and 'id' cookie updated * Test new visit where the visitor has a cookie created with Piwik.JS: PiwikTracker should read the cookie as expected
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
sabl0r
pushed a commit
to sabl0r/piwik
that referenced
this issue
Sep 23, 2014
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
See Pull request proposal: #114
This pull request adds variables, functions, and logic so PiwikTracker can update client cookies and may suffice to meet the request in ticket #3239. The code was originally derived from the patch submitted (and ultimately not-accepted) in ticket #2699. Deeper research showed that the logic inside this patch was incomplete and differed greatly from piwik.js. In response, functions in Piwik.js were copied over and translated into PHP, refactoring existing code to leverage these functions.
The text was updated successfully, but these errors were encountered: