Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set first party client cookies from PiwikTracker.php to improve dual JS-PHP tracking and data accuracy #4239

Closed
mattab opened this issue Oct 24, 2013 · 4 comments
Milestone

Comments

@mattab
Copy link
Member

@mattab mattab commented Oct 24, 2013

See Pull request proposal: #114

This pull request adds variables, functions, and logic so PiwikTracker can update client cookies and may suffice to meet the request in ticket #3239. The code was originally derived from the patch submitted (and ultimately not-accepted) in ticket #2699. Deeper research showed that the logic inside this patch was incomplete and differed greatly from piwik.js. In response, functions in Piwik.js were copied over and translated into PHP, refactoring existing code to leverage these functions.

@mattab
Copy link
Member Author

@mattab mattab commented Oct 24, 2013

In 0d5a61f: Adding first party cookie read/write to the PiwikTracker PHP client. Refs #4239
Based off the pulll request by @claytondaley and tidied up #114

@mattab
Copy link
Member Author

@mattab mattab commented Oct 24, 2013

In 0f2af69: Refs #4239 Fixing bug and adding custom variables cookie setter

TODO: we need some tests to make sure this works as expected and will not be broken in the future

  • Test new visit without a cookie: cookies 'ses' and 'id' should be created,
  • Test new page view: the 'ses' cookie should be deleted and 'id' cookie updated
  • Test new visit where the visitor has a cookie created with Piwik.JS: PiwikTracker should read the cookie as expected

@mattab
Copy link
Member Author

@mattab mattab commented Oct 24, 2013

In e285292: Load custom variables of visit scope from the cookie Refs #4239

@mattab
Copy link
Member Author

@mattab mattab commented Oct 24, 2013

In 3826fda: Enabling read/set cookies by default refs #4239

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…tter

TODO: we need some tests to make sure this works as expected and will not be broken in the future
 *  Test new visit without a cookie: cookies 'ses' and 'id' should be created,
 *  Test new page view: the 'ses' cookie should be deleted and 'id' cookie updated
 *  Test new visit where the visitor has a cookie created with Piwik.JS: PiwikTracker should read the cookie as expected
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant