Post Event only to activated plugins

[tsteur]

Currently, events are posted to all loaded plugins, not all activated plugins.

This results for instance in including JavaScript files of deactivated plugins if merge_assets are disabled, it results in Fatal Errors if a deactivated plugin listens to events and produces a fatal error etc.

[tsteur]

In e3082f7: refs #4357 post event only to activated plugins, fixed most fatals but still differences in output

[tsteur]

In 174bf3b: refs #4357 this should fix the core tests

[tsteur]

In aad58ac: refs #4357 this should fix some integration tests but not sure about the side effects

[tsteur]

In 04326ba: refs #4357 post event only to activated and loaded plugins. Usually an activated plugin should be loaded anyway, but this seems not to be the case in tests where plugins are sometimes manually unloaded. Another solution would be to remove the plugin from activated plugins list ($pluginsToLoad) when unloadPlugin() is called. Not sure about side effects

[tsteur]

In 71f1845: refs #4357 fix more tests

[tsteur]

In 034742a: refs #4357 make sure plugin name is set

[tsteur]

In d323058: refs #4357 probably a better fix to make the integration tests working

[tsteur]

In e3e45c7: refs #4357 revert unloading plugins again, could not find another way to pass all the tests

[tsteur]

Tests are green but not sure if it is safe to merge... See email

[mattab]

made a change in master:

• Tests now activate plugins explicitely. 75b1b44

[mattab]

@thomas, thanks for the investigation. Could you check whether the problem is still found in Piwik, that events are posted to the disabled plugins? If so, i'd like to have this fixed.

Otherwise if the problem was fixed somehow, maybe we can close this ticket?

[mattab]

In f96c0f1: Fixes #4357 Merging branch into master, let's see if the build stays green

[mattab]

In b647357: Refs #4357 Not fully working, so reverting

[mattab]

In e6ffa98: Refs #4357 only post events to activated plugins.
ticket is not fixed because I think other calls to getLoadedPlugins() should maybeu use this new function getPluginsLoadedAndActivated() instead.

[mattab]

In 4c9d0c3: A proper hack to be removed soon ummmmmmok? Refs #4357