Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding new annotation calendar not visible .... #4510

Closed
anonymous-piwik-user opened this issue Jan 13, 2014 · 15 comments
Assignees
Labels
Bug
Milestone

Comments

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented Jan 13, 2014

When you add new annotation calendar is not visible. It has "wrong Z index". Hard to add new annotation.

@anonymous-piwik-user

This comment has been minimized.

Copy link
Author

@anonymous-piwik-user anonymous-piwik-user commented Jan 13, 2014

@anonymous-piwik-user

This comment has been minimized.

Copy link
Author

@anonymous-piwik-user anonymous-piwik-user commented Jan 13, 2014

Issue observed with FF 26.0 and IE 11.02 (maybe with other browsers also).

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 22, 2014

btw this was fixed once in #4386 then reverted in 872781a#commitcomment-5136079

@anonymous-piwik-user

This comment has been minimized.

Copy link
Author

@anonymous-piwik-user anonymous-piwik-user commented Jan 22, 2014

In ab210e9: Fix hidden date selector for annotations.

fixes #4510

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 22, 2014

See attached file, some widgets can overflow, so maybe we find another fix

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 22, 2014

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 22, 2014

In 7f6509c: Refs #4510 Revert as it's causing visual bugs (some widget content now overflowing)

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 22, 2014

@anonymous-piwik-user

This comment has been minimized.

Copy link
Author

@anonymous-piwik-user anonymous-piwik-user commented Jan 23, 2014

In c65b1d5: Second attempt at fixing #4510. Only hide overflow-x.

refs #4510

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 27, 2014

Fyi on this screenshot: http://builds-artifacts.piwik.org/ui-tests.master/1421.1/processed-ui-screenshots/UIIntegrationTest_dashboard1.png

I now see a vertical scrollbar, maybe it can be hidden?

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 27, 2014

In 85a9e2d: Refs #4510 reverting change, I'll make UI tests build green first

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Jan 27, 2014

The UI build should be green now! still unsure how to fix this bug without adding the scroll bars...

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Feb 6, 2014

Removing owner from tickets. from now on, I suggest we assign tickets to ourselves for cases when we we plan to actively work on them in the coming days/weeks. let's discuss if needed during our team call.

@sgiehl

This comment has been minimized.

Copy link
Member

@sgiehl sgiehl commented Mar 31, 2014

Setting div.dataTable's position not to absolute fixes this issue. But I'm not sure if it has other sideeffects.

https://github.com/piwik/piwik/blob/master/plugins/CoreHome/stylesheets/dataTable/_dataTable.less#L26 (removing that line fixes the issue)

@tsteur

This comment has been minimized.

Copy link
Member

@tsteur tsteur commented May 7, 2014

In c04cdb5: fixes #4510 When adding new annotation calendar was not fully visible is dashboard

@anonymous-piwik-user anonymous-piwik-user added this to the 2.3.0 - Piwik 2.3.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.