UI bugs connected to subdatatables

[timo-bes]

Here's how to reproduce some bugs (tested in Safari and Chrome).

Go to http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=1&period=week&date=2014-01-10#module=Referrers&action=getSearchEnginesAndKeywords&idSite=1&period=week&date=2014-01-10

Bug 1:

• In Search Engines, click Google - looks OK
• Now, click Yahoo. The background of the subtable is grey - it should be white. On hover, the background is yellow - this color should not be used anymore.

(Now, refresh)

Bug 2:

• Open Google in Search Engines
• Hover the number of visits of Bing - the percentages are shown correctly
• Now, hover the label of Bing - the percentages in the Google subtable are shown

(Now, refresh)

Bug 3:

• Open any Search Engine
• Hover any row below it. The background is too dark and as a consequence, the background of the row evolution icon is visible. This does not happen for the rows above the opened one.

[mattab]

Thanks for the report!

[timo-bes]

In 88aaf3f: refs #4536 improved striping for action data tables: when subtables are opened or closed, reset the odd/even labels. otherwise, two subsequent odd or even rows are possible.

[timo-bes]

In 73a1b46: refs #4536: morpheus uses odd/even css classes instead of nth-child. this way, striping works properly on nested data tables (e.g. the search engines report). also, make the css overrides more effective (e.g. add :hover).

[timo-bes]

In 5ad9080: refs #4536 fixing indentation of previous commits

[timo-bes]

Bugs 1 and 3 from the ticket description should be gone now. Please let me know when the demo is updated so that I can test the exact steps mentioned in the description.

[timo-bes]

In baeda26: refs #4536: only show the ratio in the current table - not in a subtable. fixes bug 2 from the ticket description.

[timo-bes]

I think this ticket should be done now. As I said, I'd like to test it on the demo before closing it.

Please guys, test as much as you can. It is really hard to get this right. Open and close subtables (both tables like the pages report and tables like the search engines report) randomly and see whether you can spot another error.

[mattab]

Nice changes!

Timo we now have the demo running latest git master at http://demo2.piwik.org
you can login there with the same username pwd as on demo.

[timo-bes]

demo2 doesn't have the same data so I can't test the exact steps described above. I could reproduce the issues with data from my local environment and the problems are gone there. So I guess the bugs mentioned above are fixed now.

I'd still like to try it on the regular demo but that's not urgent. When do you think it will be updated the next time?

[mattab]

In next couple days will be updated with the RC we are preparing.

Btw I noticed a regression:

• in the admin table, such as Users, Websites, or Users permissions, the rows are now displayed in Grey rather than white background.

[timo-bes]

In 6148bb1: refs #4536 admin tables are white in morpheus

[timo-bes]

Is .entityTable the right selector to use? Please review the CSS change and test again.

[timo-bes]

I can confirm that all three bugs from the description are now gone on the demo.

[timo-bes]

In db95706: refs #4536: highlighting active plugins in the settings

[timo-bes]

A commit above broke the screenshot UI tests.

I have also asked this on [[https://github.com/piwik/piwik/commit/6148bb1532fb88da4d21e8a4c1f2903a715e4c5e#commitcomment-5330187|github]]: Who determines what is expected and how can the expected screenshots be changed?

documentation] doesn't help much. Is there more documentation on the subject?