Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE8 support #4620

Closed
mattab opened this Issue Feb 4, 2014 · 37 comments

Comments

Projects
None yet
10 participants
@mattab
Copy link
Member

commented Feb 4, 2014

At some point we should drop IE8 support.

As of January 2014 there are only ~10% of all users using IE8. On Piwik.org, we are seeing 1.3% using IE8.

Reasons:

  • This is causing extra work for cross browser testing, development, troubleshooting.
  • Since we are considering using AngularJS, and their latest version 1.3 drops IE8 support, and for other reasons, we would like to drop IE8 support.
  • In April 2014, Microsoft will be ending support for Windows XP, which means the end of support for the operating system most of Internet Explorer 8 users use.

Note:

I think we should support IE8 at least until August 2014 to give companies a few months to react after MS drops XP support.

@diosmosis

This comment has been minimized.

Copy link
Member

commented Mar 5, 2014

FYI, using http://selectivizr.com/ in ComparisonDashboard to get CSS3 selectors to work (in JavaScript & in stylesheets).

@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 12, 2014

Well, since version 2.1.0 IE8 is a messup just after "Logout" link.

Maybe the best choice would be handling unsupported browsers with an exception.

@mattab

This comment has been minimized.

Copy link
Member Author

commented May 13, 2014

I haven't tested recently, but are you saying Piwik does not work well under IE8?

@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 13, 2014

Yes, is not useful, we will deliver Firefox to all users. Open source wins.
In the meantime I took a screenshot, it's Piwik 2.2.3b3 rendered with IE8

@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 13, 2014

Attachment: Piwik 2.2.3b3 as seen by IE8
piwik-ie8.png

@tsteur

This comment has been minimized.

Copy link
Member

commented May 14, 2014

Hi tassoman,

I test Piwik with IE8 regularly and it works for me with latest beta and with 2.1.0.

  • Can you try to clear the cache in IE8? See https://kb.wisc.edu/page.php?id=12314 for more help
  • From what I understand it works with Firefox. If not, can you try to remove all files within the "tmp/assets/" and "tmp/templates_c/" directories? If you don't know how to do this you might want to consider installing the http://plugins.piwik.org/cacheBuster "CacheBuster" plugin within your Piwik under "Settings => Marketplace => Get new functionality"
  • In case you use any custom plugins, disable them and see if the error is still there
  • Maybe you can also check whether http://demo.piwik.org works for you with IE8?
@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 14, 2014

I got it. The problem is my IE8 configuration runs intranet websites in compatibility mode. So that can't render AngularJS stuff very well.

Agente utente: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; InfoPath.3)
Timestamp: Wed, 14 May 2014 08:25:09 UTC
Messaggio: [$sce:iequirks] http://errors.angularjs.org/1.2.13/$sce/iequirks
Linea: 255
Carattere: 252
Codice: 0
URI: http://vmdev.local/piwik/index.php?module=Proxy&action=getCoreJs&cb=cccc8f48b7e4934285d6711b0081b516

I've removed the flag from "run intranet websites using compatibility mode" and the render was ok.

The problem is I can't modify this option to all dozens users of the intranet.

I've found a post on MSDN describing how to handle this by sending html tags in the head section of the page but I'm not really sure it will help.

@mattab

This comment has been minimized.

Copy link
Member Author

commented May 15, 2014

but I'm not really sure it will help.

To try it you can edit the file: https://github.com/piwik/piwik/blob/master/plugins/Zeitgeist/templates/dashboard.twig#L10-10

and put the meta tag there. Then you should see the meta tag in the "Analytics report" in Piwik (but not on login screen or admin). Maybe it could make Piwik work well under IE8 for you?

@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 15, 2014

Looking at dashboard.twig template I've discovered you've already set the X-UA-Compatible tag and is set to IE=EDGE. By the way I've tried the hack but doesn't works.

So I prefer to go with no hack. Intranet compatibility is a internal setting of IE and so can't be edited by html headers.

@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 28, 2014

Well, going deeper into the IE deal I've sorted out there's a crazy bug in IE9 that makes it ignore the UA-Compatible meta tag when conditional comments are placed before it.

So that, I've hacked badly* dashboard.twig and admin.twig files removing conditional comments in html source and now IE8 it's flawlessly working also on my Piwik dev machine inside the intranet.

(* I promise to git reset --hard my local branch)

@tsteur

This comment has been minimized.

Copy link
Member

commented May 28, 2014

That's a good point. Once we remove support for IE8 we can remove the conditional comments as well and you won't have to patch it anymore ;)

@tassoman

This comment has been minimized.

Copy link
Contributor

commented May 29, 2014

Good, thanks. Just keep in mind this bug is also affecting IE9 also

@mattab

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2014

Replying to tassoman:

Well, going deeper into the IE deal I've sorted out there's a crazy bug in IE9 that makes it ignore the UA-Compatible meta tag when conditional comments are placed before it.

So that, I've hacked badly* dashboard.twig and admin.twig files removing conditional comments in html source and now IE8 it's flawlessly working also on my Piwik dev machine inside the intranet.

(* I promise to git reset --hard my local branch)

@tassoman I've created a ticket here: #5282 Include Meta tag IE=edge for best security practises

Maybe you have some comment about it? It was sent to us by email to our security email

@mattab

This comment has been minimized.

@tassoman

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2014

Replying to matt:

@tassoman maybe this stackoverflow thread is related: http://stackoverflow.com/questions/6156639/x-ua-compatible-is-set-to-ie-edge-but-it-still-doesnt-stop-compatibility-mode

Yes Matt, it's the same stuff I mentioned in comment nr.13, as you can see in the second StackOverflow most valued reply they suggest to go straight with doctype and html declaration without any conditional comment before the html and meta tag.

The first reply is about ISS7/9 but we haven't that environment so can't be helpful.

@mattab mattab added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014

@mattab mattab added T: Task labels Jul 8, 2014

@mattab mattab removed P: normal labels Aug 3, 2014

@tsteur

This comment has been minimized.

Copy link
Member

commented Sep 24, 2014

What is the current state on supporting IE8? In ticket August 2014 is mentioned. We have October 2014 soon. Can we drop support for IE8? Would like to work on #6283 To make it work on IE8 and lower we would have to somehow call document.createElement('custom-element'); for each element which is kinda annyoing. @mattab ?

@mattab

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2014

Hard to take the decision here as it would simply shut down Piwik for some corporations. Though we must do it at one point. What is status at AngularJS project support of IE8? as long as AngularJS works well on IE8 I reckon we should try to support it... unless it becomes really too time consuming...

@tassoman

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2014

Well, as Piwik user I can say for my organization, in my SSO custom plugin I'm checking that user-agent isn't MSIE by regular expression, then forcing them logging in using a different browser throwing an handled exception while at login.

Maybe this would be a community question you could solve using a poll. Can't say if integrating a 3rd parties poll plugin in core would be a good idea for tasting users opinion about a subject.

Imagine something of a small tip popping up to superadmins, just like the "New piwik update is available" thing bringing a link to the survey in a new browser tab...

@tsteur

This comment has been minimized.

Copy link
Member

commented Sep 25, 2014

Not sure about this poll. I reckon the result would be something like IE8 users voting to still support and non IE8 users will probably not really care whether we still support it or not. A problem is that we do not know how many of our users are still using IE8. We can delay #6283 but should definitely start working on it once we also start to work on using angular routes and when using it for visualizations.

AngularJS 1.2.* should still support IE8. AngularJS 1.3 will drop support for IE8 and should be released soon I reckon. At least there is already an 1.3-RC3

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 18, 2015

I'm closing this one, but not be afraid Piwik 2.X which will be supported for more than a year from now on will be compatible with IE8. Closing this issue as support will be dropped in 3.0

@tsteur tsteur closed this Aug 18, 2015

@tsteur tsteur modified the milestones: 3.0.0-b1, 3.0.0 Aug 18, 2015

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 18, 2015

Actually I will reopen as there's more to do:

  • Changelog
  • Update some code blocks where we can now use .finally() instead of ['finally'] etc

@tsteur tsteur reopened this Aug 18, 2015

@tsteur tsteur modified the milestones: 3.0.0, 3.0.0-b1 Aug 18, 2015

tsteur added a commit that referenced this issue Aug 18, 2015

@tsteur tsteur self-assigned this Aug 18, 2015

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 20, 2015

fixed via #8591. As mentioned we still support IE8 for a pretty long time but in Piwik 3.0 it will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.