Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morpheus theme makes tables in security settings partly unreadable #4682

Closed
nullnull-00 opened this issue Feb 14, 2014 · 19 comments
Closed

Morpheus theme makes tables in security settings partly unreadable #4682

nullnull-00 opened this issue Feb 14, 2014 · 19 comments
Labels
Bug
Milestone

Comments

@nullnull-00
Copy link
Contributor

@nullnull-00 nullnull-00 commented Feb 14, 2014

In Morpheus theme every second row of the tables in the security info page has white backgroud instead of green or yellow one.
This makes it impossible to read text, which should have green background(due to the white font color).

The problematic css is

.dataTable tr:nth-child(2n) td {
    background-color: rgb(255, 255, 255) !important;
}

which overrides the inline css.

See attached screenshot!

@nullnull-00
Copy link
Contributor Author

@nullnull-00 nullnull-00 commented Feb 14, 2014

Attachment:
white_tr.png

@mattab
Copy link
Member

@mattab mattab commented Feb 15, 2014

this looks fixed in latest SecurityInfo plugin and 2.1-rc1 please reopen if not!

@nullnull-00
Copy link
Contributor Author

@nullnull-00 nullnull-00 commented Feb 15, 2014

In my installation SecurityInfo-tables look even worse wit 2.1RC1, because all colors are gone now.

See the new screenshot.

@nullnull-00
Copy link
Contributor Author

@nullnull-00 nullnull-00 commented Feb 15, 2014

Attachment:
table.png

@hpvd
Copy link

@hpvd hpvd commented Feb 15, 2014

same here.
Put an other screenshot as attachment which highlights the problem a bit more...

@hpvd
Copy link

@hpvd hpvd commented Feb 15, 2014

@mattab
Copy link
Member

@mattab mattab commented Feb 16, 2014

I'm using 2.1 RC1 and the latest securityInfo plugion from the marketplace and cannot replicate this issue. I'm confused that you are getting this with latest RC...

@hpvd
Copy link

@hpvd hpvd commented Feb 17, 2014

just installed again latest master piwik from github:
everything look still the same with

  • firefox 28 and
  • opera 12.16

no new updates for plugins are shown/everything is up to date

PHP is v5.3.27

@mattab
Copy link
Member

@mattab mattab commented Feb 18, 2014

In ca55552: Refs #4682 Adding screenshot test for security info page, to see if we can replicate the bug on Travis

@mattab
Copy link
Member

@mattab mattab commented Feb 18, 2014

as you can see here: http://builds-artifacts.piwik.org/ui-tests.master/1653.1/processed-ui-screenshots/UIIntegrationTest_admin_security_info.png

the screenshot looks ok even on travis.

Can you try delete the tmp/ folder of your Piwik?

@mattab
Copy link
Member

@mattab mattab commented Feb 18, 2014

I released a new version of the Security Info plugin which I think will fix the issue! http://plugins.piwik.org/SecurityInfo

@nullnull-00
Copy link
Contributor Author

@nullnull-00 nullnull-00 commented Feb 18, 2014

Updated Piwik and the Plugin: Now everything works fine.

@hpvd
Copy link

@hpvd hpvd commented Feb 21, 2014

nearly fine ;-)
the lines which are back again now have a different green colour...

please see attachment

@hpvd
Copy link

@hpvd hpvd commented Feb 21, 2014

@mattab
Copy link
Member

@mattab mattab commented Feb 22, 2014

Screenshot looks ok, what's the problem on it?

@hpvd
Copy link

@hpvd hpvd commented Feb 22, 2014

hmm
to different green font colours are used:

#9B7A44
#468847

=> is it a feature?

see new screenshot...

@hpvd
Copy link

@hpvd hpvd commented Feb 22, 2014

@nullnull-00
Copy link
Contributor Author

@nullnull-00 nullnull-00 commented Feb 22, 2014

468847 is green("this setting is OK") -> previously green background

9B7A44 is red/brown("this setting is bad") -> previously yellow background

But I think the second color should be changed somehow, at the moment it looks more brown than red (which would fit better for the purpose of a probable security issue).

btw should there really be written

<em>disabled</em>

in allow_url_fopen ;)

@mattab
Copy link
Member

@mattab mattab commented Feb 23, 2014

Fixed in SecurityInfo 1.0.4 matomo-org/plugin-SecurityInfo@ccd5766

@nullnull-00 nullnull-00 added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…o see if we can replicate the bug on Travis
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants