Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking API speed improvement: cache parsed yaml in tracker cache (DevicesDetection) #4683

Closed
mattab opened this issue Feb 15, 2014 · 2 comments
Closed
Milestone

Comments

@mattab
Copy link
Member

@mattab mattab commented Feb 15, 2014

Parsing YML files from DevicesDetection plugin takes up to 100ms per Tracking API request. This was rather unacceptable performance... We want to move DevicesDetection to first class citizen in #3962

Stefan implemented a clever fix, to cache the parsed YML arrays in the tracker cache.

This was done in:

a3c01d6

662178b

@mattab
Copy link
Member Author

@mattab mattab commented Feb 15, 2014

Now it takes 1 ms or less to load in memory the cached files. good caching FTW

@mattab
Copy link
Member Author

@mattab mattab commented Feb 18, 2014

In 96cb532: Refs #4683 Refactor this little bit

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@mattab mattab added T: Task labels Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant