Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Currently, any non-anonymous logged-in user, can add new segment.
Expected: as a Piwik admin I want to set that only users with "view" or "admin" or "superuser" permission can create new segments.
The text was updated successfully, but these errors were encountered:
Thanks for the suggestion! See pull request: #275
Sorry, something went wrong.
In 22227f6: Merge pull request #275 from d-skora/feature/SegmentEditor
Feature/segment editor Fixes #5172
I realised the ticket description was not clear, and so the code IMHO is not correct.
I will commit some fix.
In bdc6dbb: Refs #5172 Make sure anonymous user cannot edit segments + rename superadmin to superuser for consistency
In f1c47b8: Refs #5172 Rename siteid to idSite for consistency
In a1577f2: Refs #5172 Fix bug, use proper idSite value
In 8885f29: Refs #5172 Rename config setting with a clear name, adding_segment_requires_access
idSite===false is not valid use case AFAIK so removing code that deals with that.
In 75871ca: Fixes #5172 Should be code complete
Successfully merging a pull request may close this issue.