Row evolution data export fails when filter_limit is supplied #5397

Activity

1. mattab commented on Jul 1, 2014

   

   mattab

   on Jul 1, 2014

   Member

   More actions

   It seems to affect pages URLs that contain a comma character (and maybe other characters are affected?)
2. quba commented on Jul 3, 2014

   

   quba

   on Jul 3, 2014

   Contributor

   More actions

   There's also another issue - filter_limit being applied before label filter.

   Here one example from demo.piwik.org:

   http://demo.piwik.org/index.php?module=API&method=Actions.getPageTitles&format=XML&idSite=7&period=day&date=2014-06-03,2014-07-02&expanded=1&label=Daylight%2520saving%2B&token_auth=anonymous&filter_limit=30

   That's the default one - row evolution report export.

   And here with disabled filter_limit:

   http://demo.piwik.org/index.php?module=API&method=Actions.getPageTitles&format=XML&idSite=7&period=day&date=2014-06-03,2014-07-02&expanded=1&label=Daylight%2520saving%2B&token_auth=anonymous&filter_limit=-1
3. tsteur commented on Jul 7, 2014

   

   tsteur

   on Jul 7, 2014

   Member

   More actions

   @ kuba.cc suggestion seems to be the actual issue see ResponseBuilder. I'm gonna try to move the label filter upwards just to see which test fail afterwards...
4. tsteur commented on Jul 7, 2014

   

   tsteur

   on Jul 7, 2014

   Member

   More actions

   In df3427b: refs #5397 wondering which tests will fail when applying the label filter before limit filter & co
5. tsteur commented on Jul 7, 2014

   

   tsteur

   on Jul 7, 2014

   Member

   More actions

   Tests fail after moving the label filter, see https://travis-ci.org/piwik/piwik/jobs/29283168

   I think one problem is that "SafeDecodeLabel" ( https://github.com/piwik/piwik/blob/master/core/API/ResponseBuilder.php#L319 ) is no longer executed before the LabelFilter meaning the tests should be updated meaning we would change the API.

   We could recommend to always use filter_limit = -1 when a label filter is used but doesn't sound very intuitive. Especially our export links in the UI would have to take care of this as well :( A hack to always set the filter_limit to -1 when a label filter is used results in even more problems in the end.

   So basically to keep the API the same we'd have to "undo" the SafeDecodeLabel of the label url parameter and then compare. This could work
6. tsteur commented on Jul 7, 2014

   

   tsteur

   on Jul 7, 2014

   Member

   More actions

   Couldn't really fix it without breaking anything. Maybe someone else wants to have a look?
7. mgazdzik

   added this to the 2.5.0 - Piwik 2.5.0This milestone has been deleted milestone on Jul 8, 2014
8. mgazdzik

   added

   T: Bug

   on Jul 8, 2014
9. diosmosis

   changed the title [-]Row evolution data export show no data for page URLs containing a comma[/-] [+]Row evolution data export fails when filter_limit is supplied (was: Row evolution data export show no data for page URLs containing a comma)[/+] on Jul 10, 2014
10. diosmosis commented on Jul 10, 2014

    

    diosmosis

    on Jul 10, 2014

    Member

    More actions

    Changing title since the bug is only present when a filter_limit is present.
11. mattab

    changed the title [-]Row evolution data export fails when filter_limit is supplied (was: Row evolution data export show no data for page URLs containing a comma)[/-] [+]Row evolution data export fails when filter_limit is supplied[/+] on Jul 10, 2014
12. diosmosis

    added a commit that references this issue on Jul 11, 2014

    Refs #5397, quick fix for issue where Limit filter is run before Labe…

    ...

    66e8153
13. mattab

    closed this as completedon Jul 11, 2014