Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API responses sub tables should contain same metrics as parent tables (filters should be applied recursively) #5593

mattab opened this issue Apr 5, 2008 · 1 comment
Bug For errors / faults / flaws.


Copy link

mattab commented Apr 5, 2008

For example we do:

$dataTable = $this→getDataTable(‘Actions_outlink’, $idSite, $period, $date, $expanded, $idSubtable );
$dataTable→queueFilter(‘Piwik_DataTable_Filter_ColumnCallbackAddDetail’, array(‘label’, ‘url’, create_function(‘$url’, ‘return $url;’)));


But we may want to apply the filter recursively if the returned data table has many levels (the case for actions when searching recursively for example).

I can see 2 implementations:


queueRecursiveFilter( Filter )`



both are not incompatible. The first is better in my opinion.

Copy link
Member Author

mattab commented Jan 17, 2011

(In [3764]) Fixes #5593 - making all filters recursive by default (no performance impact since it won't load the tables if they were not loaded in the API). Updating all filters to reflect new abstract class signature

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Bug For errors / faults / flaws.
None yet

No branches or pull requests

1 participant