Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installPlugins() should use installPlugin() #5744

Closed
anonymous-matomo-user opened this issue Aug 4, 2008 · 2 comments
Closed

installPlugins() should use installPlugin() #5744

anonymous-matomo-user opened this issue Aug 4, 2008 · 2 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@anonymous-matomo-user
Copy link

To avoid updating installPlugins() when installPlugin() is updated (and other way around), installPlugins() should use installPlugin():

public function installPlugins() {
foreach($this→getLoadedPlugins() as $plugin) {
try {
$this→installPlugin();
} catch(Exception $e) {
throw new Piwik_Plugin_Exception($plugin→getName(), $e→getMessage());
}
}
}
Keywords: plugins

@anonymous-matomo-user
Copy link
Author

> ```
> $this→installPlugin();
> ```
>
> correct is $this→installPlugin($plugin);

@mattab
Copy link
Member

mattab commented Sep 7, 2008

good point! fixed in 628

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants