Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage for Piwik Plugins using coveralls.io #6195

Closed
sgiehl opened this Issue Sep 11, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@sgiehl
Copy link
Member

sgiehl commented Sep 11, 2014

This is a follow up ticket to #4302
Coveralls.io is already processing code coverage reports for Piwik itself.

It would also be useful to have separate code coverage reports for plugins.

We could maybe add this feature to the default plugin template that is used when calling ./console generate:test

@sgiehl sgiehl added the Task label Sep 11, 2014

@sgiehl sgiehl added this to the Long term milestone Sep 11, 2014

@mattab mattab modified the milestones: Mid term, Long term Sep 12, 2014

@mattab mattab added the Help wanted label Sep 12, 2014

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Oct 11, 2014

Hi @sgiehl great work on this, can this ticket be closed or is some work pending? maybe you can create a new issue for ideas and next steps regarding code coverage for Piwik core + plugins ?

@sgiehl

This comment has been minimized.

Copy link
Member Author

sgiehl commented Oct 11, 2014

Code coverage for core is already working (see #4302). But I'm still working on codecoverage for plugins.

@sgiehl sgiehl self-assigned this Oct 11, 2014

@sgiehl

This comment has been minimized.

Copy link
Member Author

sgiehl commented Oct 12, 2014

I've implemented code coverage for plugins now.
It works with the autogenerated travis.yml of piwik's console tool.

See matomo-org/plugin-CustomAlerts#8

Maybe we need to update the docs somewhere and add how it works.
It's as simple as it should be:

  • Generate .travis.yml using Piwik console
  • Activate repo on coveralls.io

Done!

@diosmosis

This comment has been minimized.

Copy link
Member

diosmosis commented Oct 13, 2014

👍

1 similar comment
@diosmosis

This comment has been minimized.

Copy link
Member

diosmosis commented Oct 13, 2014

👍

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Oct 13, 2014

Awesome!

@sgiehl

This comment has been minimized.

Copy link
Member Author

sgiehl commented Oct 13, 2014

I'll close this ticket now. @mattab Shall we create a new ticket to add some information do the developer docs?

@sgiehl sgiehl closed this Oct 13, 2014

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Oct 13, 2014

@sgiehl
IIRC code coverage is automatically enabled for new plugins when using generate:plugin command so we don't need to really document.

though it would be nice to have a little note about code coverage in: https://github.com/piwik/piwik/blob/master/tests/README.md

Update: followed up in #6931 Generate Unit tests code coverage report for Plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.