New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceDetection segment editor auto suggested values should show full strings #6772

Open
mattab opened this Issue Dec 1, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@mattab
Copy link
Member

mattab commented Dec 1, 2014

The goal of this issue is to review the Device Detection segments such as browserCode and operatingSystemCode.

  • Currently the valid segment values for browserCode are FF, CH, IE, etc.
    • would be more understandable and guessage to use firefox, chrome, internet explorer etc.
    • the segment auto suggest values should contain automatically all the top browsers we know of, instead of using the Live auto suggested feature.
    • for Backward compatibility we should still accept FF, CH etc. and define firefox or Chrome as aliases to those ones.
  • Same applies to operatingSystemCode where segment values would be pretty string such as windows xp, windows 7, GNU/Linux
    • it's case insensitive, both Windows XP and windows xp will alias to WXP

Implementation: refs suggestedValuesCallback feature.

@mattab mattab added this to the Short term milestone Dec 1, 2014

@mattab mattab modified the milestones: Short term, Mid term Dec 18, 2014

@RMastop

This comment has been minimized.

Copy link
Contributor

RMastop commented Feb 5, 2015

One of the things I miss the most in devicedetection, is the concatenation of all individual reports.
For example:
a devices report containing the Devicetype + Model + Operatingsystem family + browser family + Resolution
a devices report containing the Devicetype + Model + Operatingsystem version + browser version + Resolution

This report will be really fragmented, but it will give the developers of websites a pretty nice view of the combinations of devices that visit the website. Some companies have a policy for supporting at least the top x% of most visited combination of devices.

@sgiehl

This comment has been minimized.

Copy link
Member

sgiehl commented Feb 5, 2015

@RMastop Guess your comment might be related to #6933

@RMastop

This comment has been minimized.

Copy link
Contributor

RMastop commented Feb 5, 2015

Yes, @sgiehl being able to see the combination of 'things' would be awesome!

@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016

@mattab mattab removed the Lower priority label Sep 13, 2018

@mattab mattab modified the milestones: Backlog (Help wanted), 3.10.0 Dec 10, 2018

@sgiehl sgiehl referenced a pull request that will close this issue Jan 6, 2019

Open

Readable segment values for browser and os segments #13929

@sgiehl sgiehl self-assigned this Jan 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment