Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing tmp folder in ZIP #7612

Closed
robinsherwood opened this issue Apr 1, 2015 · 9 comments
Closed

missing tmp folder in ZIP #7612

robinsherwood opened this issue Apr 1, 2015 · 9 comments
Assignees
Labels
Bug
Milestone

Comments

@robinsherwood
Copy link

@robinsherwood robinsherwood commented Apr 1, 2015

Discussion: http://forum.piwik.org/read.php?2,125778
The ZIP folder is missing the tmp folder. This seems to be a bug. Now the tmp folder is created by piwik - undeletable :(

@mattab mattab added the Task label Apr 1, 2015
@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Apr 1, 2015

Thanks @robinsherwood for report.

we used to package the tmp/ folder but seems not the case since 2.10.0 or so -

Tasks

  • add back tmp folder with .gitkeep file
  • add unit test to make sure the tmp/ folder is there in Piwik
mnapoli added a commit that referenced this issue Apr 2, 2015
@mnapoli

This comment has been minimized.

Copy link
Contributor

@mnapoli mnapoli commented Apr 2, 2015

I've pushed the folder back, which permissions was it supposed to be, 755?

@mnapoli mnapoli self-assigned this Apr 2, 2015
@robinsherwood

This comment has been minimized.

Copy link
Author

@robinsherwood robinsherwood commented Apr 3, 2015

In my active running install it is 755

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Apr 7, 2015

  • I'm not sure now what it should be but it's important to set same permission as it was before it was removed
  • let's add an automated test that will detect in case the folder is missing in the future
@mnapoli

This comment has been minimized.

Copy link
Contributor

@mnapoli mnapoli commented Apr 7, 2015

The test was added in the commit already.

I've downloaded Piwik 2.9.0 and the permissions are 755, so I'll apply those permissions.

@mnapoli

This comment has been minimized.

Copy link
Contributor

@mnapoli mnapoli commented Apr 7, 2015

Turns out that git doesn't store permissions, so it's now just like it was before.

@mnapoli mnapoli closed this Apr 7, 2015
@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Apr 20, 2015

@mnapoli could you add a unit test to verify the tmp/ folder is in git? i'm afraid otherwise we may delete it again without noticing.

@mattab

This comment has been minimized.

Copy link
Member

@mattab mattab commented Apr 20, 2015

Ok I see now that the test exists already in 2f524cc 👍

@mnapoli

This comment has been minimized.

Copy link
Contributor

@mnapoli mnapoli commented Apr 20, 2015

yes that's what I said in the comment above ;)

@mnapoli mnapoli added Bug and removed Task labels Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.