New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website selector: searching for special strings will show html code #7692

Closed
mattab opened this Issue Apr 17, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@mattab
Member

mattab commented Apr 17, 2015

Reproduce:

  • in a website selector, with 10 websites or so,
  • enter in the search field an (or any substring of `...........
  • notice that the autocompleter will highlight in purple some text but it actually displays html code of the element, as can be seen in this screenshot:

highlighter

Expected behavior would be that the html code is not displayed (and that the highlighter / search does not match on the html text but only on the text without markup)

@mattab mattab added the Bug label Apr 17, 2015

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Apr 20, 2015

Contributor

Ah I reported that here: #7552 (comment) but apparently I forgot to fix it ;)

What do you say I just remove the color highlighting? I remember looking into it and it was a mess because of escaping issues.

Contributor

mnapoli commented Apr 20, 2015

Ah I reported that here: #7552 (comment) but apparently I forgot to fix it ;)

What do you say I just remove the color highlighting? I remember looking into it and it was a mess because of escaping issues.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Apr 20, 2015

Member

color highlighting is actually useful: it shows user why the website name matches the search (which sometimes is not obvious when website names are long or when search string is short).

Member

mattab commented Apr 20, 2015

color highlighting is actually useful: it shows user why the website name matches the search (which sometimes is not obvious when website names are long or when search string is short).

@mattab mattab added this to the 2.15.0 milestone Jul 14, 2015

@tsteur tsteur self-assigned this Jul 30, 2015

tsteur added a commit that referenced this issue Jul 30, 2015

@tsteur tsteur closed this in #8467 Aug 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment