New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step "Create tables" of new installation appears untranslated #7926

Closed
PatchRanger opened this Issue May 17, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@PatchRanger

PatchRanger commented May 17, 2015

How to reproduce

Initialize a new installation of Piwik, follow the installation steps. On "Database setup" step, fill in the form with new table prefix in order to get the use-case of "tablesCreated".

Expected result

The layout of the page and the message are fully translated to the current language.

Real result

Everything from layout to appeared message (which is successful, sic) are in English, though all steps before and even after it are localized.

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl May 17, 2015

Member

I can reproduce that. Not sure why the translations are not used even if they are available.

Member

sgiehl commented May 17, 2015

I can reproduce that. Not sure why the translations are not used even if they are available.

@sgiehl sgiehl added the Bug label May 17, 2015

@PatchRanger

This comment has been minimized.

Show comment
Hide comment
@PatchRanger

PatchRanger May 18, 2015

After debugging a little, I've discovered that for that page Translator, returned by StaticContainer, has a private property currentLanguage set to en, though it's not the case for other pages.

PatchRanger commented May 18, 2015

After debugging a little, I've discovered that for that page Translator, returned by StaticContainer, has a private property currentLanguage set to en, though it's not the case for other pages.

PatchRanger added a commit to PatchRangerTempStorage/piwik that referenced this issue May 29, 2015

@mattab mattab added this to the 2.15.0 milestone Jul 15, 2015

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli Jul 27, 2015

Contributor

For the record, PR WIP: #8022

Contributor

mnapoli commented Jul 27, 2015

For the record, PR WIP: #8022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment