New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard fails to load in Firefox with 'Adblock Plus' extension #7928

Closed
joshhansen opened this Issue May 18, 2015 · 15 comments

Comments

Projects
None yet
6 participants
@joshhansen

joshhansen commented May 18, 2015

My site is running Piwik 2.13.1. Under Chrome (well, Chromium) 42 the dashboard loads fine, but under Firefox 36 (my preferred browser) I get the following error:

ReferenceError: $ is not defined index.php:68:8
ReferenceError: $ is not defined index.php:739:0
ReferenceError: $ is not defined index.php:764:0

This indicates that jQuery has not loaded properly. Without this library, the dashboard is basically worthless.

Of course, I can get by with Chrome support only, but to fail to load under Firefox seems like a serious issue and I hope it could be addressed.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab May 18, 2015

Member

Hi @joshhansen that's surprising, can you reproduce this problem on http://demo.piwik.org as well?

Member

mattab commented May 18, 2015

Hi @joshhansen that's surprising, can you reproduce this problem on http://demo.piwik.org as well?

@joshhansen

This comment has been minimized.

Show comment
Hide comment
@joshhansen

joshhansen May 19, 2015

The problem doesn't occur on the demo site. Can you help me understand why jQuery would fail to load when all HTTP requests are succeeding---but only in Firefox?

joshhansen commented May 19, 2015

The problem doesn't occur on the demo site. Can you help me understand why jQuery would fail to load when all HTTP requests are succeeding---but only in Firefox?

@mnapoli

This comment has been minimized.

Show comment
Hide comment
@mnapoli

mnapoli May 19, 2015

Contributor

@joshhansen could you have a look in the "Network" tab of the development tools? It should help to debug. It might also be an extension that is installed on Firefox (e.g. an aggressive ad blocker?) that blocks some requests.

Contributor

mnapoli commented May 19, 2015

@joshhansen could you have a look in the "Network" tab of the development tools? It should help to debug. It might also be an extension that is installed on Firefox (e.g. an aggressive ad blocker?) that blocks some requests.

@joshhansen

This comment has been minimized.

Show comment
Hide comment
@joshhansen

joshhansen May 20, 2015

Strangely enough, Adblock Plus in Firefox seems to have been causing the problem. This is especially odd since I also use Adblock Plus in Chromium, but it doesn't seem to be causing problems there. Disabling ad blocking on my Piwik site seems to be sufficient to resolve the problem.

I wonder if anyone else can reproduce this problem? It's a common enough extension that it might be worth looking into why Piwik is triggering the ad blocker.

joshhansen commented May 20, 2015

Strangely enough, Adblock Plus in Firefox seems to have been causing the problem. This is especially odd since I also use Adblock Plus in Chromium, but it doesn't seem to be causing problems there. Disabling ad blocking on my Piwik site seems to be sufficient to resolve the problem.

I wonder if anyone else can reproduce this problem? It's a common enough extension that it might be worth looking into why Piwik is triggering the ad blocker.

@mattab mattab changed the title from Dashboard fails to load in Firefox but works in Chrome to Dashboard fails to load in Firefox with 'Adblock Plus' extension Jul 15, 2015

@mattab mattab added the Bug label Jul 15, 2015

@mattab mattab added this to the Mid term milestone Jul 15, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Jul 15, 2015

Member

Good to know @joshhansen - thanks for the details.

we should contact Adblock Plus to ask them to upgrade their rules so it does not break when viewing Piwik dashboard. Maybe you would like to contact the developers and report issue to them?

Member

mattab commented Jul 15, 2015

Good to know @joshhansen - thanks for the details.

we should contact Adblock Plus to ask them to upgrade their rules so it does not break when viewing Piwik dashboard. Maybe you would like to contact the developers and report issue to them?

@hpvd

This comment has been minimized.

Show comment
Hide comment
@hpvd

hpvd Sep 11, 2015

For me this was working without any problems in the past.
About 1 month ago the problems started
for other details on this please see:
#8760

In firefox you could see the following messages in web-developer toolbar
(https://addons.mozilla.org/de/firefox/addon/web-developer/)

2015-09-11_12h00_44

hpvd commented Sep 11, 2015

For me this was working without any problems in the past.
About 1 month ago the problems started
for other details on this please see:
#8760

In firefox you could see the following messages in web-developer toolbar
(https://addons.mozilla.org/de/firefox/addon/web-developer/)

2015-09-11_12h00_44

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Sep 11, 2015

Member

We definitely need to try to detect adblocker and show a notification

Member

tsteur commented Sep 11, 2015

We definitely need to try to detect adblocker and show a notification

@mattab mattab modified the milestones: 2.15.0, Mid term Sep 11, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 11, 2015

Member

Moving to 2.15.0 - if can't be done in time, we'll do it in 2.15.x

Member

mattab commented Sep 11, 2015

Moving to 2.15.0 - if can't be done in time, we'll do it in 2.15.x

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 11, 2015

Member

Actually we will do #5094 in 2.15.0 rather

Member

mattab commented Sep 11, 2015

Actually we will do #5094 in 2.15.0 rather

@mattab mattab modified the milestones: Mid term, 2.15.0 Sep 11, 2015

@hpvd

This comment has been minimized.

Show comment
Hide comment
@hpvd

hpvd Sep 11, 2015

one should do this detection really carefully
There are lot's of methods out there which work with adding blacklisted words e.g. "advertise" to the website code the see if this is blocked.
Doing this here would be like honey and we will have problems with many many other tools/extension...

hpvd commented Sep 11, 2015

one should do this detection really carefully
There are lot's of methods out there which work with adding blacklisted words e.g. "advertise" to the website code the see if this is blocked.
Doing this here would be like honey and we will have problems with many many other tools/extension...

@hpvd

This comment has been minimized.

Show comment
Hide comment
@hpvd

hpvd Sep 11, 2015

I would suggest to understand why parts of piwik-backend are blocked

  • for website frontend with piwik script inside - it's clear: they would like to prevent any tracking
  • but why are there now problems with Piwik's backend?

hpvd commented Sep 11, 2015

I would suggest to understand why parts of piwik-backend are blocked

  • for website frontend with piwik script inside - it's clear: they would like to prevent any tracking
  • but why are there now problems with Piwik's backend?
@trendzetter

This comment has been minimized.

Show comment
Hide comment
@trendzetter

trendzetter Oct 7, 2015

Same issue with firefox and "ublock Origin" on 2.10.0.

trendzetter commented Oct 7, 2015

Same issue with firefox and "ublock Origin" on 2.10.0.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Oct 13, 2015

Member

Hello can you please test with latest piwik beta? it should now display a warning that adblock is used. please let us know if the warning works!

Member

mattab commented Oct 13, 2015

Hello can you please test with latest piwik beta? it should now display a warning that adblock is used. please let us know if the warning works!

@mattab mattab modified the milestones: 2.15.0, Mid term Oct 13, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Oct 13, 2015

Member

Re-open if the warning is not displayed for uBlock origin #5094

explanation in #5094 (comment)

Member

mattab commented Oct 13, 2015

Re-open if the warning is not displayed for uBlock origin #5094

explanation in #5094 (comment)

@mattab mattab closed this Oct 13, 2015

@tsteur

This comment has been minimized.

Show comment
Hide comment
@tsteur

tsteur Oct 13, 2015

Member

It is not directly related to uBlock origin but to the lists that are activated. Eg one needs to enable the EasyPrivacy list in any ad blocker and this will happen. I think by default it did not block anything.

Member

tsteur commented Oct 13, 2015

It is not directly related to uBlock origin but to the lists that are activated. Eg one needs to enable the EasyPrivacy list in any ad blocker and this will happen. I think by default it did not block anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment